Skip to content

src: fix -Wunreachable-code-return in node_sea #57664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

src: fix -Wunreachable-code-return in node_sea #57664

merged 1 commit into from
Apr 23, 2025

Conversation

codebytere
Copy link
Member

As in title - correct the following:

../../third_party/electron_node/src/node_sea.cc:641:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  641 |   return false;
      |          ^~~~~
1 error generated.

@codebytere codebytere requested a review from joyeecheung March 28, 2025 14:15
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Mar 28, 2025
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. labels Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66369/

@codebytere codebytere added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7bc37af into nodejs:main Apr 23, 2025
76 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7bc37af

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@codebytere @RafaelGSS
src: fix -Wunreachable-code-return in node_sea
44c2ef6 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@codebytere @RafaelGSS
src: fix -Wunreachable-code-return in node_sea
09206e9 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
852bb62 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
b6ab677 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@codebytere @RafaelGSS
src: fix -Wunreachable-code-return in node_sea
ab34e4c 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
a6fd445 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
019902e 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
4d6a96c 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
b071d19 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
0c7d952 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@codebytere @aduh95
src: fix -Wunreachable-code-return in node_sea
ca020fd 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@codebytere @marco-ippolito
src: fix -Wunreachable-code-return in node_sea
30cc6c3 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@codebytere @marco-ippolito
src: fix -Wunreachable-code-return in node_sea
a96eab5 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 5, 2025
Open
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@codebytere @marco-ippolito
src: fix -Wunreachable-code-return in node_sea
c01fd4c 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@codebytere @marco-ippolito
src: fix -Wunreachable-code-return in node_sea
c0252cd 
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@legendecas legendecas legendecas approved these changes

@aymen94 aymen94 aymen94 approved these changes

@tony-go tony-go tony-go approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@codebytere @nodejs-github-bot @lpinca @dsanders11 @legendecas @aymen94 @tony-go @RaisinTen @aduh95