Skip to content

src: add --run-from flag#57592

Open
flakey5 wants to merge 6 commits into
nodejs:mainfrom
flakey5:flakey5/57489
Open

src: add --run-from flag#57592
flakey5 wants to merge 6 commits into
nodejs:mainfrom
flakey5:flakey5/57489

Conversation

@flakey5

@flakey5 flakey5 commented Mar 22, 2025

Copy link
Copy Markdown
Member

Closes #57489

This differs from #57523 in that this changes the working directory that the script is executed from.

@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 22, 2025
@flakey5 @mertcanaltin @anonrig
src: add --run-from flag
1745412 
Closes nodejs#57489

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

Co-authored-by: Mert Can Altin <mertgold60@gmail.com>
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
@flakey5
remove debug statement
390e692 
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@codecov

codecov Bot commented Mar 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.23%. Comparing base (4a7d501) to head (6dc382a).
⚠️ Report is 2627 commits behind head on main.

Files with missing lines Patch % Lines
src/node_task_runner.cc 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57592      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         630      630              
  Lines      185149   185065      -84     
  Branches    36235    36222      -13     
==========================================
- Hits       167066   166989      -77     
- Misses      11037    11046       +9     
+ Partials     7046     7030      -16
Files with missing lines Coverage Δ
src/node_options.cc 85.36% <100.00%> (+0.01%) ⬆️
src/node_options.h 98.88% <ø> (ø)
src/node_task_runner.cc 86.70% <40.00%> (-2.69%) ⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini

pmarchini commented Mar 22, 2025

Copy link
Copy Markdown
Member

Is this a duplicate of #57523?

@jasnell

jasnell commented Mar 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@pmarchini ... it is a simpler alternative to #57523. @flakey5 had started working on it before #57523 was opened based on the discussion in the original issue.

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 22, 2025
@anonrig anonrig added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 22, 2025
@github-actions

github-actions Bot commented Mar 22, 2025

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

GeoffreyBooth
GeoffreyBooth reviewed Mar 23, 2025
View reviewed changes
Comment thread doc/api/cli.md Outdated
Comment thread src/node_options.cc Outdated
@flakey5 @GeoffreyBooth
Apply suggestions from code review
4e28d16 
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
atlowChemi
atlowChemi reviewed Mar 23, 2025
View reviewed changes
Comment thread doc/api/cli.md
ovflowd
ovflowd reviewed Mar 23, 2025
View reviewed changes
Comment thread src/node_task_runner.cc
ovflowd
ovflowd reviewed Mar 23, 2025
View reviewed changes
Comment thread src/node_task_runner.cc Outdated
ovflowd
ovflowd approved these changes Mar 23, 2025
View reviewed changes

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a minor comment, that might lead to misunderstandings on the expected behavior, but besides that, cool stuff!

@flakey5
update man page
8567c83 
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
mertcanaltin
mertcanaltin approved these changes Mar 23, 2025
View reviewed changes

@mertcanaltin mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

targos
targos reviewed Mar 24, 2025
View reviewed changes
Comment thread doc/api/cli.md Outdated
@flakey5
only allow a directory to be passed in
52f7ca0 
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
jasnell
jasnell reviewed Mar 24, 2025
View reviewed changes
Comment thread doc/api/cli.md Outdated
jasnell
jasnell reviewed Mar 25, 2025
View reviewed changes
Comment thread doc/api/cli.md Outdated
@flakey5 @jasnell
Update doc/api/cli.md
6dc382a 
Co-authored-by: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Mar 25, 2025

Copy link
Copy Markdown
Member

I think this change is generally ready to go but due to some ongoing maintenance issues with CI we are restricted from running jenkins CI on this PR just yet. Once that is opened back up we can run CI and get this merged.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2025
@github-actions github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 1, 2025
@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: add `--run-from` flag
   ⚠  - remove debug statement
   ⚠  - Apply suggestions from code review
   ⚠  - update man page
   ⚠  - only allow a directory to be passed in
   ⚠  - Update doc/api/cli.md
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14195007818

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66053/

@aduh95

aduh95 commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

There's a related test failure:

---
duration_ms: 914.731
exitcode: 1
severity: fail
stack: |-
  Test failure: 'runs script in a custom working directory using --run-from'
  Location: test/parallel/test-node-run.js:226:3
  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + ''
  - '/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/run-script'

@ovflowd

ovflowd commented Apr 11, 2025

Copy link
Copy Markdown
Member

There's a related test failure:

---
duration_ms: 914.731
exitcode: 1
severity: fail
stack: |-
  Test failure: 'runs script in a custom working directory using --run-from'
  Location: test/parallel/test-node-run.js:226:3
  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + ''
  - '/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/run-script'

☝️ @flakey5

@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments
@targos targos targos left review comments
@ovflowd ovflowd ovflowd approved these changes
@anonrig anonrig anonrig approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specify working directory for node --run