Skip to content

src: improve error message for invalid child stdio type in spawn_sync #57589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

src: improve error message for invalid child stdio type in spawn_sync #57589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/spawn_sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,10 @@ Maybe<int> SyncProcessRunner::ParseStdioOption(int child_fd,
return Just(AddStdioInheritFD(child_fd, inherit_fd));
}

UNREACHABLE("invalid child stdio type");
Utf8Value stdio_type(env()->isolate(), js_type);
fprintf(stderr, "invalid child stdio type: %s\n", stdio_type.out());

UNREACHABLE();
}

int SyncProcessRunner::AddStdioIgnore(uint32_t child_fd) {
Expand Down
Loading