Skip to content

net: make _setSimultaneousAccepts() end-of-life deprecated #57550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -2554,12 +2554,15 @@ undocumented `COUNTER_NET_SERVER_CONNECTION()`,

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/57550
description: End-of-Life.
- version: v12.0.0
pr-url: https://github.com/nodejs/node/pull/23760
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The undocumented `net._setSimultaneousAccepts()` function was originally
intended for debugging and performance tuning when using the
Expand Down
39 changes: 0 additions & 39 deletions lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -2473,48 +2473,9 @@ Server.prototype.unref = function() {
return this;
};

let _setSimultaneousAccepts;
let warnSimultaneousAccepts = true;

if (isWindows) {
let simultaneousAccepts;

_setSimultaneousAccepts = function(handle) {
if (warnSimultaneousAccepts) {
process.emitWarning(
'net._setSimultaneousAccepts() is deprecated and will be removed.',
'DeprecationWarning', 'DEP0121');
warnSimultaneousAccepts = false;
}
if (handle === undefined) {
return;
}

if (simultaneousAccepts === undefined) {
simultaneousAccepts = (process.env.NODE_MANY_ACCEPTS &&
process.env.NODE_MANY_ACCEPTS !== '0');
}

if (handle._simultaneousAccepts !== simultaneousAccepts) {
handle.setSimultaneousAccepts(!!simultaneousAccepts);
handle._simultaneousAccepts = simultaneousAccepts;
}
};
} else {
_setSimultaneousAccepts = function() {
if (warnSimultaneousAccepts) {
process.emitWarning(
'net._setSimultaneousAccepts() is deprecated and will be removed.',
'DeprecationWarning', 'DEP0121');
warnSimultaneousAccepts = false;
}
};
}

module.exports = {
_createServerHandle: createServerHandle,
_normalizeArgs: normalizeArgs,
_setSimultaneousAccepts,
get BlockList() {
BlockList ??= require('internal/blocklist').BlockList;
return BlockList;
Expand Down
18 changes: 0 additions & 18 deletions test/parallel/test-net-deprecated-setsimultaneousaccepts.js

This file was deleted.

This file was deleted.

Loading