[v22.x backport] sqlite,test,doc: allow Buffer and URL as database location#57533
Closed
geeksilva97 wants to merge 2 commits intonodejs:v22.x-stagingfrom
Closed
[v22.x backport] sqlite,test,doc: allow Buffer and URL as database location#57533geeksilva97 wants to merge 2 commits intonodejs:v22.x-stagingfrom
geeksilva97 wants to merge 2 commits intonodejs:v22.x-stagingfrom
Conversation
PR-URL: nodejs#56991 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
|
This shouldn't land without the changes in #57227 |
Contributor
Author
What's the procedure? Two backports? |
Member
|
You can push to this PR |
Contributor
Author
Cool. Will do. |
PR-URL: nodejs#57227 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
geeksilva97
commented
Mar 18, 2025
github-actions
bot
removed
the
request-ci
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Mar 19, 2025
Contributor
Author
|
Hmm, that's new for me. Coverage thresholds are not being fulfilled. But it is a backport 🤔 . |
geeksilva97
added
the
author ready
Member
We have a problem with coverage on v22.x. It's unrelated to your PR. |
RafaelGSS
approved these changes
Mar 20, 2025
Member
|
Landed in be79f4a...2746524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #56991
Reviewed-By: Colin Ihrig cjihrig@gmail.com