Skip to content

[v22.x backport] sqlite,test,doc: allow Buffer and URL as database location #57533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v22.x backport] sqlite,test,doc: allow Buffer and URL as database location #57533

wants to merge 2 commits into from

Conversation

geeksilva97
Copy link
Contributor

PR-URL: #56991
Reviewed-By: Colin Ihrig cjihrig@gmail.com

@geeksilva97
sqlite,test,doc: allow Buffer and URL as database location
6bb9155 
PR-URL: nodejs#56991
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Mar 18, 2025
@geeksilva97 geeksilva97 mentioned this pull request Mar 18, 2025
Closed
@anonrig
Copy link
Member

anonrig commented Mar 18, 2025

This shouldn't land without the changes in #57227

@geeksilva97
Copy link
Contributor Author

This shouldn't land without the changes in #57227

What's the procedure? Two backports?

@anonrig
Copy link
Member

anonrig commented Mar 18, 2025

You can push to this PR

@geeksilva97
Copy link
Contributor Author

You can push to this PR

Cool. Will do.

@anonrig @geeksilva97
src: reduce string allocations on sqlite
265e6fb 
PR-URL: nodejs#57227
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
geeksilva97
geeksilva97 commented Mar 18, 2025
View reviewed changes
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65830/

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65839/

@geeksilva97 geeksilva97 requested review from cjihrig and anonrig March 19, 2025 18:12
cjihrig
cjihrig approved these changes Mar 19, 2025
View reviewed changes
@geeksilva97
Copy link
Contributor Author

Hmm, that's new for me. Coverage thresholds are not being fulfilled. But it is a backport 🤔 .

@geeksilva97 geeksilva97 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2025
@RafaelGSS
Copy link
Member

Hmm, that's new for me. Coverage thresholds are not being fulfilled. But it is a backport 🤔 .

We have a problem with coverage on v22.x. It's unrelated to your PR.

RafaelGSS pushed a commit that referenced this pull request Mar 31, 2025
@geeksilva97 @RafaelGSS
sqlite,test,doc: allow Buffer and URL as database location
81bb03f 
PR-URL: #56991
Backport-PR-URL: #57533
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Mar 31, 2025
@anonrig @RafaelGSS
src: reduce string allocations on sqlite
2746524 
PR-URL: #57227
Backport-PR-URL: #57533
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #56991
@RafaelGSS
Copy link
Member

Landed in be79f4a...2746524

@RafaelGSS RafaelGSS closed this Mar 31, 2025
RafaelGSS pushed a commit that referenced this pull request Mar 31, 2025
@geeksilva97 @RafaelGSS
sqlite,test,doc: allow Buffer and URL as database location
227603d 
PR-URL: #56991
Backport-PR-URL: #57533
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Mar 31, 2025
@anonrig @RafaelGSS
src: reduce string allocations on sqlite
a68f127 
PR-URL: #57227
Backport-PR-URL: #57533
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@geeksilva97 geeksilva97 deleted the backport-56991-to-v22.x branch May 20, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geeksilva97 @nodejs-github-bot @anonrig @RafaelGSS @cjihrig