repl: deprecate `repl.builtinModules` #57508

dario-piotrowicz · 2025-03-16T22:36:51Z

juanarbol

Amazing, thanks! If CI is happy, I'm happy as well.

aduh95 · 2025-03-16T23:15:04Z

~~Can you please open a PR that first doc-deprecates the API?~~ Hum actually, I'm not sure whether --pending-deprecation changes would be semver-major, so that might be fine EDIT2: just checked, we have precedents for landing as semver-patch pending deprecations

doc/api/repl.md

doc/api/deprecations.md

nodejs-github-bot · 2025-03-17T00:31:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65794/

codecov · 2025-03-17T01:30:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (1123585) to head (e9fd52f).
Report is 61 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57508   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185063    +8     
  Branches    36216    36221    +5     
=======================================
+ Hits       166975   166989   +14     
- Misses      11042    11043    +1     
+ Partials     7038     7031    -7

Files with missing lines	Coverage Δ
lib/repl.js	`94.91% <100.00%> (+0.02%)`	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/repl.js

BridgeAR

I would actually like to keep this around and just fix the issue. The reason is that we expose underscored modules in Module one and those should never be used.

The current issue with the repl exposed one is that it filters node: prefixed ones out. That should not be the case.

We can also update the documentation to say "all besides underscored'.

aduh95 · 2025-03-17T09:54:09Z

I would actually like to keep this around

Any particular reason for that? Do you have a use-case in mind?

BridgeAR

LGTM

I do overall agree that this should not exist on the repl, since we already have it exposed elsewhere.

I suggest to deprecate the runtime usage of the underscored modules as well in different PRs.

nodejs-github-bot · 2025-04-04T08:28:34Z

Commit Queue failed

- Loading data for nodejs/node/pull/57508
✔  Done loading data for nodejs/node/pull/57508
----------------------------------- PR info ------------------------------------
Title      repl: deprecate `repl.builtinModules` (#57508)
Author     Dario Piotrowicz <dario.piotrowicz@gmail.com> (@dario-piotrowicz)
Branch     dario-piotrowicz:dario/57504/deprecate-repl-builtinmodules -> nodejs:main
Labels     repl, author ready, needs-ci
Commits    1
 - repl: deprecate `repl.builtinModules`
Committers 1
 - Dario Piotrowicz <dario@cloudflare.com>
PR-URL: https://github.com/nodejs/node/pull/57508
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57508
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 16 Mar 2025 22:36:51 GMT
   ✔  Approvals: 6
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688852607
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688878116
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688878596
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/57508#pullrequestreview-2689145592
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2712875322
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2696025170
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-03-17T00:31:48Z: https://ci.nodejs.org/job/node-test-pull-request/65794/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - repl: deprecate `repl.builtinModules`
- Querying data for job/node-test-pull-request/65794/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14261203802

nodejs-github-bot · 2025-04-04T08:52:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66019/

nodejs-github-bot · 2025-04-04T14:01:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66023/

nodejs-github-bot · 2025-04-05T13:40:20Z

Landed in e232b4a

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#57508 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #57508 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Mar 16, 2025

dario-piotrowicz mentioned this pull request Mar 16, 2025

repl.builtinModules doesn't contain all node.js builtin modules #57504

Closed

dario-piotrowicz force-pushed the dario/57504/deprecate-repl-builtinmodules branch 7 times, most recently from 39271fa to f38edf8 Compare March 16, 2025 22:45

juanarbol approved these changes Mar 16, 2025

View reviewed changes

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 16, 2025

aduh95 reviewed Mar 16, 2025

View reviewed changes

doc/api/repl.md Outdated Show resolved Hide resolved

aduh95 reviewed Mar 16, 2025

View reviewed changes

doc/api/repl.md Outdated Show resolved Hide resolved

aduh95 removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 16, 2025

This comment was marked as outdated.

Sign in to view

aduh95 reviewed Mar 17, 2025

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

aduh95 approved these changes Mar 17, 2025

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 17, 2025

jasnell approved these changes Mar 17, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2025

meixg approved these changes Mar 17, 2025

View reviewed changes

Lxxyx reviewed Mar 17, 2025

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

BridgeAR requested changes Mar 17, 2025

View reviewed changes

dario-piotrowicz force-pushed the dario/57504/deprecate-repl-builtinmodules branch from 37cfc74 to e9fd52f Compare March 25, 2025 00:08

BridgeAR approved these changes Mar 25, 2025

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 4, 2025

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 4, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025

Lxxyx approved these changes Apr 4, 2025

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025

nodejs-github-bot merged commit e232b4a into nodejs:main Apr 5, 2025
67 checks passed

dario-piotrowicz deleted the dario/57504/deprecate-repl-builtinmodules branch April 5, 2025 14:11

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

AuntyEms mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

repl: deprecate `repl.builtinModules` #57508

repl: deprecate `repl.builtinModules` #57508

Uh oh!

dario-piotrowicz commented Mar 16, 2025

Uh oh!

juanarbol left a comment

Uh oh!

aduh95 commented Mar 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

nodejs-github-bot commented Mar 17, 2025

Uh oh!

codecov bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

BridgeAR left a comment

Uh oh!

aduh95 commented Mar 17, 2025

Uh oh!

BridgeAR left a comment

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 5, 2025

Uh oh!

Uh oh!

Uh oh!

repl: deprecate repl.builtinModules #57508

repl: deprecate repl.builtinModules #57508

Uh oh!

Conversation

dario-piotrowicz commented Mar 16, 2025

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

nodejs-github-bot commented Mar 17, 2025

Uh oh!

codecov bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Mar 17, 2025

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

nodejs-github-bot commented Apr 4, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 5, 2025

Uh oh!

Uh oh!

repl: deprecate `repl.builtinModules` #57508

repl: deprecate `repl.builtinModules` #57508

aduh95 commented Mar 16, 2025 •

edited

Loading

codecov bot commented Mar 17, 2025 •

edited

Loading