Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: backport --zero-fill-buffers command line option #5748

Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 16, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

buffer

Description of change

This backports the --zero-fill-buffers command line flag introduced in master. When used, all Buffer and SlowBuffer instances will zero fill by default.

This does not backport any of the other Buffer API or behavior changes.

Note: My intent is to open similar backports for --zero-fill-buffer in v5, v4, and v0.10

/cc @trevnorris @nodejs/lts

@jasnell jasnell added buffer Issues and PRs related to the buffer subsystem. semver-minor PRs that contain new features and should be released in the next minor version. v0.12 labels Mar 16, 2016
@jasnell
Copy link
Member Author

jasnell commented Mar 16, 2016

Talking to @trevnorris about this, he suggested just changing the behavior of smalloc if --zero-fill-buffers is set.

This backports the --zero-fill-buffers command line flag introduced
in master. When used, all Buffer and SlowBuffer instances will zero
fill by default.

This does *not* backport any of the other Buffer API or behavior
changes.
@jasnell
Copy link
Member Author

jasnell commented Mar 17, 2016

@nodejs/ctc

@jasnell
Copy link
Member Author

jasnell commented Mar 23, 2016

CTC decision today to hold off landing this in v0.12 for now. Will keep the PR open. @nodejs/lts

@jasnell
Copy link
Member Author

jasnell commented May 1, 2016

Closing. Can reopen if we ultimately decide to do this.

@jasnell jasnell closed this May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant