Merged
Conversation
Collaborator
Author
|
Review requested:
|
aduh95
approved these changes
Mar 14, 2025
Collaborator
Author
targos
approved these changes
Mar 14, 2025
cjihrig
approved these changes
Mar 14, 2025
Collaborator
Author
RafaelGSS
approved these changes
Mar 14, 2025
LiviaMedeiros
approved these changes
Mar 14, 2025
BridgeAR
approved these changes
Mar 14, 2025
Collaborator
Author
srl295
approved these changes
Mar 14, 2025
lpinca
approved these changes
Mar 15, 2025
richardlau
approved these changes
Mar 15, 2025
ba467b0 to
f5e3519
Compare
Collaborator
Author
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/57455 ✔ Done loading data for nodejs/node/pull/57455 ----------------------------------- PR info ------------------------------------ Title deps: update icu to 77.1 (#57455) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-icu -> nodejs:main Labels test, author ready, needs-ci, dependencies, icu Commits 1 - deps: update icu to 77.1 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update icu to 77.1 ℹ This PR was created on Fri, 14 Mar 2025 08:43:53 GMT ✔ Approvals: 9 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2684804758 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2684904804 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57455#pullrequestreview-2685315977 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2685691098 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686220630 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686223444 ✔ - Steven R Loomis (@srl295): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686819657 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57455#pullrequestreview-2687950616 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2688112647 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-03-16T00:39:52Z: https://ci.nodejs.org/job/node-test-pull-request/65773/ - Querying data for job/node-test-pull-request/65773/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13881700089 |
Collaborator
Author
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/57455 ✔ Done loading data for nodejs/node/pull/57455 ----------------------------------- PR info ------------------------------------ Title deps: update icu to 77.1 (#57455) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-icu -> nodejs:main Labels test, author ready, needs-ci, dependencies, icu Commits 1 - deps: update icu to 77.1 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update icu to 77.1 ℹ This PR was created on Fri, 14 Mar 2025 08:43:53 GMT ✔ Approvals: 9 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2684804758 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2684904804 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57455#pullrequestreview-2685315977 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2685691098 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686220630 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686223444 ✔ - Steven R Loomis (@srl295): https://github.com/nodejs/node/pull/57455#pullrequestreview-2686819657 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57455#pullrequestreview-2687950616 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57455#pullrequestreview-2688112647 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-03-16T13:47:09Z: https://ci.nodejs.org/job/node-test-pull-request/65781/ - Querying data for job/node-test-pull-request/65781/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13886756909 |
Collaborator
Author
|
Landed in ab9660b |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #57455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of icu to 77.1.