test: remove unnecessary assert requiring from tests #57008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Feb 12, 2025
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57008 +/- ##
=======================================
Coverage 89.09% 89.10%
=======================================
Files 665 665
Lines 193191 193191
Branches 37211 37207 -4
=======================================
+ Hits 172130 172135 +5
- Misses 13762 13776 +14
+ Partials 7299 7280 -19 |
|
Why though? |
it just simplifies the code (even though it's very minimal)? 🙂 |
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cc7018e |
dario-piotrowicz
deleted the
dario/remove-unnecessary-require-assert-from-tests
branch
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anonrig as per #56983 (comment) 🙂