[v18.x] tools: fix failing GHA workflows#56995
Merged
aduh95 merged 1 commit intonodejs:v18.x-stagingfrom Feb 10, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
aduh95
added
fast-track
aduh95
force-pushed
the
v18-fix-failing-gha
branch
from
a93ae20 to
b0d6079
Compare
aduh95
changed the title
richardlau
approved these changes
Feb 10, 2025
aduh95
force-pushed
the
v18-fix-failing-gha
branch
from
b0d6079 to
f19bb82
Compare
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
juanarbol
approved these changes
Feb 10, 2025
marco-ippolito
approved these changes
Feb 10, 2025
Contributor
Author
|
Landed in a7f565f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix landed on
mainwith an unrelated commit (021cf91#diff-0d4336c14130a2e69ae463aa9dc439815825ee04ce8419ca65b3428d2af83f17), it seems better to make a new PR for it than to attempt to cherry-pick the original commit.