Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos #5678

Closed
wants to merge 3 commits into from
Closed

doc: fix typos #5678

wants to merge 3 commits into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Mar 12, 2016

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

fs, dgram, addons

Description of change

addons:

  • Abstrations => Abstractions

dgram:

  • containins => contains
  • enecoding => encoding

fs:

  • responsiblity => responsibility

@claudiorodriguez claudiorodriguez added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 12, 2016
@zkat
Copy link
Contributor

zkat commented Mar 12, 2016

LGTM! Hi, @watilde-san! 👋

@evanlucas
Copy link
Contributor

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/1911/ (just because the addons docs are used for tests).

Thanks!!!

@thefourtheye
Copy link
Contributor

The failed test is not related to this change. LGTM

@watilde
doc: fix typo in api/fs
01ced07 
PR-URL: nodejs#5678
Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@watilde
doc: fix typo in api/dgram
e82ae20 
PR-URL: nodejs#5678
Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@watilde
doc: fix typo in api/addons
53ee9a5 
PR-URL: nodejs#5678
Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@watilde watilde changed the title Fix typos doc: fix typos Mar 14, 2016
@watilde
Copy link
Member Author

watilde commented Mar 14, 2016

Okey rebased and re-wrote commit messages :)

@cjihrig
Copy link
Contributor

cjihrig commented Mar 14, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Mar 14, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 14, 2016
@watilde @jasnell
doc: fix typo in api/fs
3cde96e 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 14, 2016
@watilde @jasnell
doc: fix typo in api/dgram
b98d53b 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 14, 2016
@watilde @jasnell
doc: fix typo in api/addons
23df9d9 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 14, 2016

Landed in 3cde96e, b98d53b, and 23df9d9

@jasnell jasnell closed this Mar 14, 2016
@watilde watilde deleted the fix-typos branch March 14, 2016 15:56
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@watilde @evanlucas
doc: fix typo in api/addons
770c0c5 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@watilde @evanlucas
doc: fix typo in api/dgram
87adcda 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@watilde @evanlucas
doc: fix typo in api/fs
6b25fd1 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Merged
@Fishrock123
Copy link
Contributor

@watilde First commits I see! Welcome! 👏 :D

rvagg pushed a commit that referenced this pull request Mar 16, 2016
@watilde @rvagg
doc: fix typo in api/fs
44a9b10 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@watilde @rvagg
doc: fix typo in api/dgram
8e45c9d 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@watilde @rvagg
doc: fix typo in api/addons
c579507 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

the only commit of the bunch that applied to v4.x is 23df9d9

Adding both the land-on and dont-land tags

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@watilde
doc: fix typo in api/addons
0552c8a 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@watilde
doc: fix typo in api/addons
dd79419 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@watilde
doc: fix typo in api/addons
07e71b2 
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@watilde @zkat @evanlucas @thefourtheye @cjihrig @jasnell @Fishrock123 @MylesBorins @claudiorodriguez