Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: add aggregate function #56600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Jan 14, 2025

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 14, 2025
@cjihrig
Copy link
Contributor

cjihrig commented Jan 20, 2025

Also, tests and docs are needed.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 11, 2025

@geeksilva97 are you still planning to work on this?

@geeksilva97
Copy link
Contributor Author

@geeksilva97 are you still planning to work on this?

Hi @cjihrig . Yes, I plan to continue this. The last few weeks have been tough though. If nobody beats me I plan to get this done by April.

@geeksilva97 geeksilva97 added the wip Issues and PRs that are still a work in progress. label Mar 15, 2025
@geeksilva97 geeksilva97 force-pushed the sqlite-aggregate-function branch 7 times, most recently from beaf983 to 70dff34 Compare March 19, 2025 13:00
@geeksilva97 geeksilva97 marked this pull request as ready for review March 19, 2025 13:01
@geeksilva97 geeksilva97 force-pushed the sqlite-aggregate-function branch from 70dff34 to f4e4869 Compare March 19, 2025 13:17
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 56.73469% with 106 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (1de917b) to head (f4e4869).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 56.73% 79 Missing and 27 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56600      +/-   ##
==========================================
- Coverage   90.23%   90.19%   -0.05%     
==========================================
  Files         629      629              
  Lines      184903   185184     +281     
  Branches    36223    36278      +55     
==========================================
+ Hits       166853   167019     +166     
- Misses      11010    11098      +88     
- Partials     7040     7067      +27     
Files with missing lines Coverage Δ
src/node_sqlite.h 70.00% <ø> (ø)
src/node_sqlite.cc 75.44% <56.73%> (-3.05%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97
Copy link
Contributor Author

I got an implementation that works. I need to add tests and clean up the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node:sqlite: sqlite module should provide wrapper for sqlite3_create_window_function api
5 participants