-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite: add aggregate function #56600
base: main
Are you sure you want to change the base?
Conversation
Also, tests and docs are needed. |
@geeksilva97 are you still planning to work on this? |
Hi @cjihrig . Yes, I plan to continue this. The last few weeks have been tough though. If nobody beats me I plan to get this done by April. |
beaf983
to
70dff34
Compare
70dff34
to
f4e4869
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56600 +/- ##
==========================================
- Coverage 90.23% 90.19% -0.05%
==========================================
Files 629 629
Lines 184903 185184 +281
Branches 36223 36278 +55
==========================================
+ Hits 166853 167019 +166
- Misses 11010 11098 +88
- Partials 7040 7067 +27
🚀 New features to boost your workflow:
|
I got an implementation that works. I need to add tests and clean up the code. |
Closes #56511
inspired by https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#aggregatename-options---this