test: remove test-macos-app-sandbox flaky designation #56471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56471 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01%
==========================================
Files 657 657
Lines 190719 190761 +42
Branches 36605 36607 +2
==========================================
+ Hits 168848 168907 +59
- Misses 15040 15044 +4
+ Partials 6831 6810 -21 |
aduh95
added
dont-land-on-v18.x
dont-land-on-v20.x
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jan 6, 2025
daeyeon
approved these changes
Jan 7, 2025
daeyeon
added
the
author ready
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 75b9c1c |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jan 13, 2025
Fixes: nodejs#54811 Refs: nodejs#54811 (comment) PR-URL: nodejs#56471 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #54811
Refs: #54811 (comment)