-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
module: fixing url change in load sync hook chain #56402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
084e18a
module: fixing url change in load sync hook chain
awto 5451b58
more readable test
awto 15872d6
Update test/module-hooks/test-module-hooks-load-url-change.js
awto d90bd6a
Update test/module-hooks/test-module-hooks-load-url-change.js
awto a239975
url rewriting for import
awto 09003dd
a test of import and a fix for windows
awto cd26b45
lint fixes
awto f60c6df
linter fix
awto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
test/module-hooks/test-module-hooks-load-url-change-import.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { mustCall } from '../common/index.mjs'; | ||
import assert from 'node:assert'; | ||
import { registerHooks } from 'node:module'; | ||
import { fileURL } from '../common/fixtures.mjs'; | ||
|
||
// This tests shows the url parameter in `load` can be changed in the `nextLoad` call | ||
// It changes `foo` package name into `redirected-fs` and then loads `redirected-fs` | ||
|
||
const hook = registerHooks({ | ||
resolve(specifier, context, nextResolve) { | ||
assert.strictEqual(specifier, 'foo'); | ||
return { | ||
url: 'foo://bar', | ||
shortCircuit: true, | ||
}; | ||
}, | ||
load: mustCall(function load(url, context, nextLoad) { | ||
assert.strictEqual(url, 'foo://bar'); | ||
return nextLoad(fileURL('module-hooks', 'redirected-fs.js').href, context); | ||
}), | ||
}); | ||
|
||
assert.strictEqual((await import('foo')).exports_for_test, 'redirected fs'); | ||
|
||
hook.deregister(); |
30 changes: 30 additions & 0 deletions
30
test/module-hooks/test-module-hooks-load-url-change-require.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const { registerHooks } = require('module'); | ||
const fixtures = require('../common/fixtures'); | ||
|
||
// This tests shows the url parameter in `load` can be changed in the `nextLoad` call | ||
// It changes `foo` package name into `redirected-fs` and then loads `redirected-fs` | ||
|
||
const hook = registerHooks({ | ||
resolve(specifier, context, nextResolve) { | ||
assert.strictEqual(specifier, 'foo'); | ||
return { | ||
url: 'foo://bar', | ||
shortCircuit: true, | ||
}; | ||
}, | ||
load: common.mustCall(function load(url, context, nextLoad) { | ||
assert.strictEqual(url, 'foo://bar'); | ||
return nextLoad( | ||
fixtures.fileURL('module-hooks', 'redirected-fs.js').href, | ||
context, | ||
); | ||
}), | ||
}); | ||
|
||
assert.strictEqual(require('foo').exports_for_test, 'redirected fs'); | ||
|
||
hook.deregister(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.