[v22.x backport] module: add module.stripTypeScriptTypes #56208

marco-ippolito · 2024-12-10T14:58:11Z

These commits are all related and sequential

nodejs-github-bot · 2024-12-10T14:58:17Z

Review requested:

@nodejs/loaders
@nodejs/startup

github-actions · 2024-12-10T15:07:52Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/12258957548

nodejs-github-bot · 2024-12-10T21:10:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63983/

aduh95 · 2024-12-10T21:34:05Z

Can you please rebase?

nodejs-github-bot · 2024-12-11T10:57:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63996/

nodejs-github-bot · 2024-12-11T13:49:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64001/

marco-ippolito · 2024-12-13T18:29:46Z

Linting failures are unrelated to the PR...

aduh95 · 2024-12-13T19:52:32Z

I've fixed the linter, can you please rebase?

nodejs-github-bot · 2024-12-14T07:39:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64050/

nodejs-github-bot · 2024-12-14T12:45:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64053/

nodejs-github-bot · 2024-12-16T06:53:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64067/

marco-ippolito · 2024-12-16T13:09:20Z

@nodejs/build I get this weird failure on windows 🤔

targos · 2024-12-16T14:40:12Z

There isn't this error in the current build (still running)

richardlau · 2024-12-16T14:43:15Z

@nodejs/build I get this weird failure on windows 🤔

I think it's due to e03be6b -- this was reverted on main by #56151 and the build machines updated to the newer Visual Studio version: nodejs/build#3963 (comment)

richardlau · 2024-12-16T14:50:49Z

There isn't this error in the current build (still running)

I'm really confused by https://ci.nodejs.org/job/node-test-pull-request/64067/ -- it seems to link to https://ci.nodejs.org/job/node-test-commit/76453/ but that is for #56271.

https://ci.nodejs.org/job/node-test-pull-request/64067/console shows

06:53:48 Starting build job node-test-commit at 01:53:48.
06:53:48 Counting node-test-commit. enabledIndex=1
10:46:47 node-test-commit: Quiet period groovy=[index < 5 ? 0 : 2 * 60], index=1 -> quietPeriodGroovy=0
10:46:47 quiet period for node-test-commit is 0 seconds.Finished Build : #76448 of Job : node-test-commit with status : FAILURE at 05:46:47
10:46:47 Starting to gather test results!

and https://ci.nodejs.org/job/node-test-commit/76448/ does show the failure.

PR-URL: nodejs#55440 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#55282 Fixes: nodejs#54300 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: nodejs#55536 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot · 2024-12-18T13:39:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64101/

nodejs-github-bot · 2024-12-19T13:07:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64118/

PR-URL: #55440 Backport-PR-URL: #56208 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #55282 Backport-PR-URL: #56208 Fixes: #54300 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: #55536 Backport-PR-URL: #56208 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

ruyadorno · 2024-12-20T17:10:28Z

Landed in 5d92a5f...016d609

PR-URL: #55440 Backport-PR-URL: #56208 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #55282 Backport-PR-URL: #56208 Fixes: #54300 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: #55536 Backport-PR-URL: #56208 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

marco-ippolito marked this pull request as ready for review December 10, 2024 14:58

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Dec 10, 2024

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. module Issues and PRs related to the module subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 10, 2024

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2024

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Dec 10, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2024

marco-ippolito force-pushed the backport-strip-typescript-types branch from 5b60e37 to 27465d9 Compare December 11, 2024 10:47

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024

JakobJingleheimer approved these changes Dec 11, 2024

View reviewed changes

marco-ippolito force-pushed the backport-strip-typescript-types branch from 27465d9 to fb9416c Compare December 13, 2024 18:22

aduh95 force-pushed the v22.x-staging branch from fdd7a20 to 9fcea1b Compare December 13, 2024 19:48

aduh95 requested a review from a team as a code owner December 13, 2024 19:48

aduh95 force-pushed the v22.x-staging branch from 9fcea1b to 1377528 Compare December 13, 2024 23:32

marco-ippolito force-pushed the backport-strip-typescript-types branch from fb9416c to 2756f71 Compare December 14, 2024 07:23

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2024

aduh95 approved these changes Dec 14, 2024

View reviewed changes

aduh95 force-pushed the v22.x-staging branch from 2dd61ae to 5d92a5f Compare December 18, 2024 11:38

marco-ippolito force-pushed the backport-strip-typescript-types branch from 2756f71 to 8451932 Compare December 18, 2024 12:59

marco-ippolito added 3 commits December 18, 2024 14:00

marco-ippolito force-pushed the backport-strip-typescript-types branch from 8451932 to 587f3e8 Compare December 18, 2024 13:00

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2024

This comment was marked as outdated.

Sign in to view

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2024

ruyadorno approved these changes Dec 20, 2024

View reviewed changes

ruyadorno closed this Dec 20, 2024

Uh oh!

[v22.x backport] module: add module.stripTypeScriptTypes #56208

[v22.x backport] module: add module.stripTypeScriptTypes #56208

Uh oh!

Conversation

marco-ippolito commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 10, 2024

Uh oh!

github-actions bot commented Dec 10, 2024

Uh oh!

nodejs-github-bot commented Dec 10, 2024

Uh oh!

aduh95 commented Dec 10, 2024

Uh oh!

nodejs-github-bot commented Dec 11, 2024

Uh oh!

nodejs-github-bot commented Dec 11, 2024

Uh oh!

marco-ippolito commented Dec 13, 2024

Uh oh!

aduh95 commented Dec 13, 2024

Uh oh!

nodejs-github-bot commented Dec 14, 2024

Uh oh!

nodejs-github-bot commented Dec 14, 2024

Uh oh!

nodejs-github-bot commented Dec 16, 2024

Uh oh!

marco-ippolito commented Dec 16, 2024

Uh oh!

targos commented Dec 16, 2024

Uh oh!

richardlau commented Dec 16, 2024

Uh oh!

richardlau commented Dec 16, 2024

Uh oh!

nodejs-github-bot commented Dec 18, 2024

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Dec 19, 2024

Uh oh!

ruyadorno commented Dec 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

marco-ippolito commented Dec 10, 2024 •

edited

Loading