lib: resolve the issue of not adhering to the specified buffersize #55896

0hmX · 2024-11-17T17:27:03Z

We create a queueHandler, and in every iteration we execute the handlers in the queueHandler until we get a non-null result.

0hmX · 2024-11-17T17:40:11Z

@Ethan-Arrowood, please take a look at the PR when you have a chance. It should be ready for merge unless some any issues is found!

codecov · 2024-11-19T06:19:41Z

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (556f1ae) to head (dba2d27).
Report is 1003 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/dir.js	80.48%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55896      +/-   ##
==========================================
+ Coverage   88.00%   88.53%   +0.53%     
==========================================
  Files         656      657       +1     
  Lines      188999   190413    +1414     
  Branches    35989    36554     +565     
==========================================
+ Hits       166331   168589    +2258     
+ Misses      15848    15007     -841     
+ Partials     6820     6817       -3

Files with missing lines	Coverage Δ
lib/internal/fs/dir.js	`95.05% <80.48%> (-2.17%)`	⬇️

... and 117 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Ethan-Arrowood · 2024-11-29T16:51:03Z

Looking good. Have you tested it locally by running the relevant fs readdir and opendir recursive test files?

I'm not really sure if this needs a unique test as you are more just improving an existing solution.

I requested a CI run now and we'll see how this does.

Thanks for the contribution!

nodejs-github-bot · 2024-11-29T16:51:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63781/

0hmX · 2024-11-29T17:32:16Z

Looking good. Have you tested it locally by running the relevant fs readdir and opendir recursive test files?

Yes, I've tested it. It should be good unless I missed something.

I'm not really sure if this needs a unique test as you are more just improving an existing solution.

Agreed. I don't think we need a new test since, as you mentioned, nothing fundamentally new was added.

nodejs-github-bot · 2024-11-30T01:14:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63800/

Ethan-Arrowood · 2024-11-30T03:50:53Z

Looks good to me, and CI is passing! Thank you, lets gets this merged.

nodejs-github-bot · 2024-11-30T03:57:17Z

Commit Queue failed

- Loading data for nodejs/node/pull/55896
✔  Done loading data for nodejs/node/pull/55896
----------------------------------- PR info ------------------------------------
Title      lib: resolve the issue of not adhering to the specified buffersize (#55896)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cu8code:55723 -> nodejs:main
Labels     fs, needs-ci
Commits    1
 - lib: resolve the issue of not adhering to the specified buffer size
Committers 1
 - cu8code <git8ankanroy@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/55896
Refs: https://github.com/nodejs/node/issues/55764
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55896
Refs: https://github.com/nodejs/node/issues/55764
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 17 Nov 2024 17:27:03 GMT
   ✔  Approvals: 1
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/55896#pullrequestreview-2470703507
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-11-30T01:14:02Z: https://ci.nodejs.org/job/node-test-pull-request/63800/
- Querying data for job/node-test-pull-request/63800/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/12093348479

Ethan-Arrowood · 2024-11-30T05:10:06Z

Hm i thought the CI run succeeded. I'll see if a retry helps.

nodejs-github-bot · 2024-11-30T05:17:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63808/

We create a `queueHandler`, and in every iteration we execute the handlers in the `queueHandler` until we get a non-null result.

nodejs-github-bot · 2025-01-06T18:55:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64375/

Ethan-Arrowood · 2025-01-06T19:01:37Z

Keep an eye on that CI run. Lets make sure nothing is failing because of these changes. I haven't ran the CI recently so I'm unaware of current known flakey tests, but they are usually pretty obvious.

edilson258 · 2025-04-21T15:12:05Z

@0hmX, are U planing to move with this fix?? i would like to help

0hmX · 2025-04-21T15:20:14Z

@edilson258 I do not plan to / know how to fix the failing tests. If you can help, I would appreciate it!

edilson258 · 2025-04-21T15:25:58Z

Is there a way of accessing the CI logs or any other way of seeing the failure reason?? @Ethan-Arrowood ?

Ethan-Arrowood · 2025-04-21T15:43:06Z

Once the CI runs (again fresh) it will comment the result here. That link will be show any failures and details as to why

nodejs-github-bot · 2025-04-21T15:47:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66404/

0hmX · 2025-04-26T13:12:26Z

@Ethan-Arrowood I think this is ready to be merged!

nodejs-github-bot · 2025-04-26T15:38:17Z

Landed in a8a86b3

Ethan-Arrowood · 2025-04-28T14:59:42Z

Great work @0hmX ! Thank you for your contribution - apologies it took so long to land! Next one should be faster 🏎️

We create a `queueHandler`, and in every iteration we execute the handlers in the `queueHandler` until we get a non-null result. PR-URL: #55896 Refs: #55764 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 17, 2024

anonrig requested a review from Ethan-Arrowood November 19, 2024 04:56

0hmX mentioned this pull request Nov 29, 2024

Support bufferSize option with recursive mode in fs.opendir #55764

Open

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024

Ethan-Arrowood approved these changes Nov 30, 2024

View reviewed changes

Ethan-Arrowood added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 30, 2024

Ethan-Arrowood added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2024

lib: resolve the issue of not adhering to the specified buffer size

dba2d27

We create a `queueHandler`, and in every iteration we execute the handlers in the `queueHandler` until we get a non-null result.

0hmX force-pushed the 55723 branch from f9c605c to dba2d27 Compare December 5, 2024 15:46

0hmX requested a review from Ethan-Arrowood December 6, 2024 14:04

Ethan-Arrowood added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2024

Ethan-Arrowood approved these changes Dec 9, 2024

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2025

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025

Ethan-Arrowood added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2025

nodejs-github-bot merged commit a8a86b3 into nodejs:main Apr 26, 2025
78 checks passed

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

AuntyEms mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

Uh oh!

lib: resolve the issue of not adhering to the specified buffersize #55896

lib: resolve the issue of not adhering to the specified buffersize #55896

Uh oh!

Conversation

0hmX commented Nov 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0hmX commented Nov 17, 2024

Uh oh!

codecov bot commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Ethan-Arrowood commented Nov 29, 2024

Uh oh!

nodejs-github-bot commented Nov 29, 2024

Uh oh!

0hmX commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 30, 2024

Uh oh!

Ethan-Arrowood commented Nov 30, 2024

Uh oh!

nodejs-github-bot commented Nov 30, 2024

Uh oh!

Ethan-Arrowood commented Nov 30, 2024

Uh oh!

nodejs-github-bot commented Nov 30, 2024

Uh oh!

nodejs-github-bot commented Jan 6, 2025

Uh oh!

Ethan-Arrowood commented Jan 6, 2025

Uh oh!

edilson258 commented Apr 21, 2025

Uh oh!

0hmX commented Apr 21, 2025

Uh oh!

edilson258 commented Apr 21, 2025

Uh oh!

Ethan-Arrowood commented Apr 21, 2025

Uh oh!

nodejs-github-bot commented Apr 21, 2025

Uh oh!

0hmX commented Apr 26, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

Ethan-Arrowood commented Apr 28, 2025

Uh oh!

Uh oh!

0hmX commented Nov 17, 2024 •

edited

Loading

codecov bot commented Nov 19, 2024 •

edited

Loading

0hmX commented Nov 29, 2024 •

edited

Loading