Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove outdated remarks about highWaterMark in fs #55462

Merged

Conversation

isker
Copy link
Contributor

@isker isker commented Oct 20, 2024

Readable's highWaterMark has in fact been 64KiB since #52037.

`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Oct 20, 2024
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2024
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4320e1a into nodejs:main Oct 22, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4320e1a

aduh95 pushed a commit that referenced this pull request Oct 23, 2024
`Readable`'s `highWaterMark` has in fact been 64KiB since #52037.

PR-URL: #55462
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037.

PR-URL: nodejs#55462
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants