Skip to content

doc: edit onboarding guide to clarify when mailmap addition is needed #55334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

doc: edit onboarding guide to clarify when mailmap addition is needed #55334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a3734
doc: edit onboarding guide to clarify when mailmap addition is needed
aduh95 Oct 9, 2024
0145c77
Update onboarding.md
aduh95 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,14 @@ needs to be pointed out separately during the onboarding.
`git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94`
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* The PR should include an addition to the
[mailmap](.mailmap) file if the email
being added to the collaborator list does not match the email used for
commits. Otherwise tooling will not see the collaborator as being active and
may suggest removing them. See
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
format of the mailmap file.
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
* Commit, including a `Fixes: <collaborator-nomination-issue-url>` trailer
so that when the commit lands, the nomination issue url will be
automatically closed.
* Run `tools/find-inactive-collaborators.mjs`. If that command outputs your name,
amend the commit to include an addition to the [mailmap](.mailmap) file. See
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
format of the mailmap file.
* Push the commit to your own fork.
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
comment in the pull request asking collaborators to approve the pull request
Expand Down
Loading