esm: mark import attributes and JSON module as stable #55333

nicolo-ribaudo · 2024-10-09T12:49:10Z

The two proposals reached stage 4 yesterday, at the October 2024 meeting. The Node.js implementation already matches exactly the semantics required by the proposals. This PR can/should be backported to 22 and 20 (and 18?).

nodejs-github-bot · 2024-10-09T12:49:15Z

Review requested:

@nodejs/loaders

doc/api/esm.md

test/es-module/test-esm-json.mjs

The two proposals reached stage 4 at the October 2024 meeting.

github-actions · 2024-10-09T14:06:13Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @richardlau.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

codecov · 2024-10-09T15:07:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (7178588) to head (9d6689a).
Report is 183 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55333      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files         652      652              
  Lines      186740   186739       -1     
  Branches    36036    36029       -7     
==========================================
+ Hits       165058   165078      +20     
+ Misses      14934    14925       -9     
+ Partials     6748     6736      -12

Files with missing lines	Coverage Δ
lib/internal/modules/esm/translators.js	`93.09% <ø> (-0.02%)`	⬇️

... and 20 files with indirect coverage changes

RedYetiDev · 2024-10-09T15:18:24Z

test/es-module/test-esm-json.mjs

+  it('should not print an experimental warning', async () => {
    const { code, signal, stderr } = await spawnPromisified(execPath, [
      fixtures.path('/es-modules/json-modules.mjs'),
    ]);

-    assert.match(stderr, /ExperimentalWarning: Importing JSON modules/);
+    assert.strictEqual(stderr, '');
    assert.strictEqual(code, 0);
    assert.strictEqual(signal, null);
  });


IMO this test case can just be removed, because there is no longer any code suggesting that an experimental emitting case.

nodejs-github-bot · 2024-10-09T15:23:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63009/

nodejs-github-bot · 2024-10-10T06:56:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63020/

mcollina

lgtm

nicolo-ribaudo · 2024-10-10T07:56:19Z

Process question: what does it mean to get multiple approvals after a comment suggesting a change? Should I delete the test or not?

marco-ippolito · 2024-10-10T08:17:49Z

Process question: what does it mean to get multiple approvals after a comment suggesting a change? Should I delete the test or not?

I think its fine to keep it

nodejs-github-bot · 2024-10-11T18:52:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63052/

nodejs-github-bot · 2024-10-11T22:42:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63059/

nodejs-github-bot · 2024-10-12T11:21:10Z

Landed in d881fcb

The two proposals reached stage 4 at the October 2024 meeting. PR-URL: nodejs#55333 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513

The two proposals reached stage 4 at the October 2024 meeting. PR-URL: nodejs#55333 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513

The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

viceice · 2024-11-07T11:34:26Z

Shouldn't this also backported to v22 ?

aduh95 · 2024-11-07T12:14:59Z

Shouldn't this also backported to v22 ?

Node.js 22.x is an active LTS, backports there are implied for non-semver-major commits. It should be in the next release.

Notable changes: esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 PR-URL: TODO

Notable changes: esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 PR-URL: #55768

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Oct 9, 2024

aduh95 reviewed Oct 9, 2024

View reviewed changes

doc/api/esm.md Outdated Show resolved Hide resolved

aduh95 reviewed Oct 9, 2024

View reviewed changes

test/es-module/test-esm-json.mjs Outdated Show resolved Hide resolved

nicolo-ribaudo force-pushed the json-modules-remove-warning branch from 3adddfc to 4c5a857 Compare October 9, 2024 12:56

aduh95 reviewed Oct 9, 2024

View reviewed changes

test/es-module/test-esm-json.mjs Outdated Show resolved Hide resolved

esm: mark import attributes and JSON module as stable

9d6689a

The two proposals reached stage 4 at the October 2024 meeting.

nicolo-ribaudo force-pushed the json-modules-remove-warning branch from 7bd1342 to 9d6689a Compare October 9, 2024 13:48

richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x notable-change PRs with changes that should be highlighted in changelogs. labels Oct 9, 2024

anonrig approved these changes Oct 9, 2024

View reviewed changes

RedYetiDev reviewed Oct 9, 2024

View reviewed changes

RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 9, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2024

aduh95 approved these changes Oct 9, 2024

View reviewed changes

marco-ippolito approved these changes Oct 10, 2024

View reviewed changes

targos approved these changes Oct 10, 2024

View reviewed changes

mcollina approved these changes Oct 10, 2024

View reviewed changes

lpinca approved these changes Oct 10, 2024

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2024

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2024

nodejs-github-bot merged commit d881fcb into nodejs:main Oct 12, 2024
79 checks passed

nicolo-ribaudo deleted the json-modules-remove-warning branch October 12, 2024 12:47

nicolo-ribaudo mentioned this pull request Oct 24, 2024

What is status of JSON modules? #55508

Closed

aduh95 mentioned this pull request Oct 24, 2024

V23.1.0 proposal #55513

Merged

aduh95 added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Nov 2, 2024

aduh95 added a commit that referenced this pull request Nov 7, 2024

2024-11-12, Version 18.20.5 'Hydrogen' (LTS)

8bc7c38

Notable changes: esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 PR-URL: TODO

aduh95 mentioned this pull request Nov 7, 2024

2024-11-12, Version 18.20.5 'Hydrogen' (LTS) #55768

Merged

aduh95 added a commit that referenced this pull request Nov 7, 2024

2024-11-12, Version 18.20.5 'Hydrogen' (LTS)

f73db8f

Notable changes: esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 PR-URL: #55768

aduh95 added a commit that referenced this pull request Nov 12, 2024

2024-11-12, Version 18.20.5 'Hydrogen' (LTS)

f17b9a4

Notable changes: esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 PR-URL: #55768

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: mark import attributes and JSON module as stable #55333

esm: mark import attributes and JSON module as stable #55333

nicolo-ribaudo commented Oct 9, 2024 •

edited

Loading

nodejs-github-bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

codecov bot commented Oct 9, 2024 •

edited

Loading

RedYetiDev Oct 9, 2024

nodejs-github-bot commented Oct 9, 2024

nodejs-github-bot commented Oct 10, 2024

mcollina left a comment

nicolo-ribaudo commented Oct 10, 2024

marco-ippolito commented Oct 10, 2024

nodejs-github-bot commented Oct 11, 2024

nodejs-github-bot commented Oct 11, 2024

nodejs-github-bot commented Oct 12, 2024

viceice commented Nov 7, 2024

aduh95 commented Nov 7, 2024

esm: mark import attributes and JSON module as stable #55333

esm: mark import attributes and JSON module as stable #55333

Conversation

nicolo-ribaudo commented Oct 9, 2024 • edited Loading

nodejs-github-bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

RedYetiDev Oct 9, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 9, 2024

nodejs-github-bot commented Oct 10, 2024

mcollina left a comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Oct 10, 2024

marco-ippolito commented Oct 10, 2024

nodejs-github-bot commented Oct 11, 2024

nodejs-github-bot commented Oct 11, 2024

nodejs-github-bot commented Oct 12, 2024

viceice commented Nov 7, 2024

aduh95 commented Nov 7, 2024

nicolo-ribaudo commented Oct 9, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading