deps: V8: partially cherry-pick 8953e49478#55274
Closed
bnoordhuis wants to merge 1 commit intonodejs:v22.x-stagingfrom
Closed
deps: V8: partially cherry-pick 8953e49478#55274bnoordhuis wants to merge 1 commit intonodejs:v22.x-stagingfrom
bnoordhuis wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
Very partial cherry-pick of upstream commit v8/v8@8953e49478 that fixes a hang that shows up in debug builds because of a buggy sanity check when computing relationships between command line flags. Example of the hang: #include "v8.h" #include "libplatform/libplatform.h" int main(void) { // works: v8::V8::SetFlagsFromString("--gc-global --noincremental-marking"); v8::V8::SetFlagsFromString("--gc-global"); v8::V8::SetFlagsFromString("--noincremental-marking"); v8::V8::InitializePlatform(v8::platform::NewDefaultPlatform().release()); v8::V8::Initialize(); // hangs in ComputeFlagListHash when defined(DEBUG) }
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
targos
approved these changes
Oct 5, 2024
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
gengjiawen
approved these changes
Oct 5, 2024
Collaborator
Collaborator
lpinca
approved these changes
Oct 6, 2024
bnoordhuis
added
commit-queue
targos
removed
the
commit-queue
Collaborator
Member
|
Commit queue would have failed. |
Member
Author
|
That cannot be anything but a flake because this change only affects debug builds. |
Member
|
Yes, but automation cannot know that. Now it's green. |
targos
added
commit-queue
targos
pushed a commit
that referenced
this pull request
Oct 7, 2024
Very partial cherry-pick of upstream commit v8/v8@8953e49478 that fixes a hang that shows up in debug builds because of a buggy sanity check when computing relationships between command line flags. Example of the hang: #include "v8.h" #include "libplatform/libplatform.h" int main(void) { // works: v8::V8::SetFlagsFromString("--gc-global --noincremental-marking"); v8::V8::SetFlagsFromString("--gc-global"); v8::V8::SetFlagsFromString("--noincremental-marking"); v8::V8::InitializePlatform(v8::platform::NewDefaultPlatform().release()); v8::V8::Initialize(); // hangs in ComputeFlagListHash when defined(DEBUG) } PR-URL: #55274 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Commit queue doesn't work with release branches. Landed in 2f65b3f. |
Merged
marco-ippolito
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very partial cherry-pick of upstream commit v8/v8@8953e49478 that fixes a hang that shows up in debug builds because of a buggy sanity check when computing relationships between command line flags.
Example of the hang:
NB: fix already exists in main; newer V8