Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding kevin uehara as collaborator #55233

Conversation

kevinuehara
Copy link
Contributor

In this PR I'm adding kevinuehara as colloaborator of node

Contribution: #54929

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 2, 2024
@aduh95
Copy link
Contributor

aduh95 commented Oct 2, 2024

Hello, please see the GOVERNANCE document regarding how one can become a collaborator. It's the one case where the project requires an issue before opening a PR.

node/GOVERNANCE.md

Lines 130 to 180 in bc39796

### Who can nominate Collaborators?
Existing Collaborators can nominate someone to become a Collaborator.
### Ideal Nominees
Nominees should have significant and valuable contributions across the Node.js
organization.
Contributions can be:
* Opening pull requests.
* Comments and reviews.
* Opening new issues.
* Participation in other projects, teams, and working groups of the Node.js
organization.
### Nominating a new Collaborator
To nominate a new Collaborator, open an issue in the [nodejs/node][] repository.
Provide a summary of the nominee's contributions. For example:
* Commits in the [nodejs/node][] repository.
* Use the link `https://github.com/nodejs/node/commits?author=GITHUB_ID`
* Pull requests and issues opened in the [nodejs/node][] repository.
* Use the link `https://github.com/nodejs/node/issues?q=author:GITHUB_ID`
* Comments on pull requests and issues in the [nodejs/node][] repository
* Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID`
* Reviews on pull requests in the [nodejs/node][] repository
* Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID`
* Help provided to end-users and novice contributors
* Pull requests and issues opened throughout the Node.js organization
* Use the link `https://github.com/search?q=author:GITHUB_ID+org:nodejs`
* Comments on pull requests and issues throughout the Node.js organization
* Use the link `https://github.com/search?q=commenter:GITHUB_ID+org:nodejs`
* Participation in other projects, teams, and working groups of the Node.js
organization
* Other participation in the wider Node.js community
Mention @nodejs/collaborators in the issue to notify other collaborators about
the nomination.
The nomination passes if no collaborators oppose it after one week. In the case
of an objection, the TSC is responsible for working with the individuals
involved and finding a resolution.
There are steps a nominator can take in advance to make a nomination as
frictionless as possible. To request feedback from other collaborators in
private, use the [collaborators discussion page][]
(which only collaborators may view). A nominator may also work with the
nominee to improve their contribution profile.

Note that the governance document uses "contributions" (plural), you're linking to a single one, you're more likely to be nominated if you make several contributions. But if you disagree, the last sentence is rellevant:

node/GOVERNANCE.md

Lines 182 to 184 in bc39796

Collaborators might overlook someone with valuable contributions. In that case,
the contributor may open an issue or contact a collaborator to request a
nomination.

@aduh95 aduh95 closed this Oct 2, 2024
@RedYetiDev RedYetiDev added invalid Issues and PRs that are invalid. and removed doc Issues and PRs related to the documentations. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issues and PRs that are invalid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants