src: track BaseObjects with an efficient list #55104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
RedYetiDev
reviewed
Sep 24, 2024
RedYetiDev
reviewed
Sep 24, 2024
src/README.md
Outdated
Comment on lines
764
to
765
| libuv objects is performed automatically, i.e. handles are closed and requests | ||
| are cancelled if possible. |
There was a problem hiding this comment.
Suggested change
| libuv objects is performed automatically, i.e. handles are closed and requests | |
| are cancelled if possible. | |
| libuv objects is performed automatically, (i.e. handles are closed and requests | |
| are cancelled, if possible). |
There was a problem hiding this comment.
Thanks for the suggestion but I don't think it is necessary to add parentheses here.
src/README.md
Outdated
| #### Cleanup realms and BaseObjects | ||
|
|
||
| Realm cleanup depends on the realm types. All realms are destroyed when the | ||
| [`Environment`][] is destroyed with cleanup hook. A [`ShadowRealm`][] can also |
There was a problem hiding this comment.
Suggested change
| [`Environment`][] is destroyed with cleanup hook. A [`ShadowRealm`][] can also | |
| [`Environment`][] is destroyed with [a/the] cleanup hook. A [`ShadowRealm`][] can also |
legendecas
force-pushed
the
realm/base-obj
branch
from
74b8541
to
778da3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55104 +/- ##
==========================================
- Coverage 88.24% 88.24% -0.01%
==========================================
Files 651 651
Lines 183877 183867 -10
Branches 35858 35855 -3
==========================================
- Hits 162266 162253 -13
- Misses 14901 14904 +3
Partials 6710 6710
|
joyeecheung
reviewed
Sep 25, 2024
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Sep 25, 2024
legendecas
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55104 ✔ Done loading data for nodejs/node/pull/55104 ----------------------------------- PR info ------------------------------------ Title src: track BaseObjects with an efficient list (#55104) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:realm/base-obj -> nodejs:main Labels c++, lib / src, author ready, needs-ci Commits 1 - src: track BaseObjects with an efficient list Committers 1 - Chengzhong Wu <legendecas@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55104 Refs: https://github.com/nodejs/node/pull/54880 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55104 Refs: https://github.com/nodejs/node/pull/54880 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 24 Sep 2024 16:11:00 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55104#pullrequestreview-2327733103 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/55104#pullrequestreview-2328639766 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-09-26T08:31:26Z: https://ci.nodejs.org/job/node-test-pull-request/62782/ - Querying data for job/node-test-pull-request/62782/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11056331072 |
|
Landed in 8496670 |
legendecas
removed
the
commit-queue-failed
|
I had to remove from v22.x-staging because it failed in GitHub CI (I think I didn't catch it because |
targos
added
the
backport-requested-v22.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55104 Refs: nodejs#54880 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BaseObjects are internal structs, use a linked list to efficiently
maintain the tracking list. This also makes iterating BaseObject list
efficient as it no longer needs to compare the
BaseObject::DeleteMecleanup callback.
Refs: #54880