test: merge knownGlobals in common#54915
Closed
avivkeller wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
nodejs-github-bot
added
needs-ci
avivkeller
force-pushed
the
patch-134
branch
from
41561a8 to
5754899
Compare
avivkeller
force-pushed
the
patch-134
branch
from
5754899 to
4799bf6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54915 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 651 651
Lines 183409 183409
Branches 35822 35829 +7
==========================================
- Hits 161519 161512 -7
- Misses 15148 15157 +9
+ Partials 6742 6740 -2 |
Contributor
|
I still think #42056 would be a better approach |
Member
Author
|
Closing in favor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
knownGlobalsarray can be simplified, as shown in this PR