test_runner: report coverage thresholds in `test:coverage` #54813

avivkeller · 2024-09-06T16:17:34Z

Fixes #54812

Adds a thresholds object to test:coverage's summary property.

nodejs-github-bot · 2024-09-06T16:17:39Z

Review requested:

@nodejs/test_runner

codecov · 2024-09-06T17:44:54Z

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (ce19715) to head (45db682).
Report is 224 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/test.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54813      +/-   ##
==========================================
+ Coverage   87.60%   87.90%   +0.29%     
==========================================
  Files         650      651       +1     
  Lines      182943   183351     +408     
  Branches    35399    35709     +310     
==========================================
+ Hits       160270   161168     +898     
+ Misses      15936    15465     -471     
+ Partials     6737     6718      -19

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	`20.69% <100.00%> (+0.97%)`	⬆️
lib/internal/test_runner/test.js	`96.93% <0.00%> (ø)`

... and 87 files with indirect coverage changes

mcollina

lgtm

doc/api/test.md

avivkeller · 2024-09-07T22:12:01Z

This PR also fixes an issue that (I believe) is causing #53937 to have failing tests.

cjihrig

Requesting changes since this has the approvals to land.

doc/api/test.md

lib/internal/main/test_runner.js

lib/internal/test_runner/harness.js

cjihrig

LGTM with minor comments.

doc/api/test.md

lib/internal/test_runner/test.js

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

github-actions · 2024-09-09T23:15:42Z

Failed to start CI

   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/10782754798

nodejs-github-bot · 2024-09-10T15:46:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62263/

avivkeller · 2024-09-12T17:08:41Z

The CI appears to have been aborted, can a new one be started in its place?

nodejs-github-bot · 2024-09-12T17:59:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62367/

nodejs-github-bot · 2024-09-12T19:52:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62375/

nodejs-github-bot · 2024-09-13T02:57:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62384/

avivkeller · 2024-09-13T12:14:40Z

CI is 🟢

nodejs-github-bot · 2024-09-13T13:31:39Z

Landed in 99bbf80

PR-URL: #54813 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

avivkeller · 2024-09-16T14:29:48Z

Is this semver-minor and/or notable change? I know it's being released in v22.9.0, but it does add new information, so I wanted to be sure.

PR-URL: #54813 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#54813 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 6, 2024

avivkeller added the coverage Issues and PRs related to native coverage support. label Sep 6, 2024

avivkeller force-pushed the report-coverage-thresholds branch from 6694361 to 5da8384 Compare September 6, 2024 16:20

avivkeller mentioned this pull request Sep 6, 2024

Running tests with --test-coverage-branches (same for lines|functions) doesn't emit test:fail when threshold isn't met #54812

Closed

mcollina approved these changes Sep 7, 2024

View reviewed changes

rozzilla reviewed Sep 7, 2024

View reviewed changes

doc/api/test.md Show resolved Hide resolved

avivkeller force-pushed the report-coverage-thresholds branch from 5da8384 to e981149 Compare September 7, 2024 22:11

avivkeller mentioned this pull request Sep 7, 2024

test_runner: add coverage support to run function #53937

Merged

avivkeller force-pushed the report-coverage-thresholds branch from e981149 to c77fee6 Compare September 7, 2024 22:12

MoLow approved these changes Sep 8, 2024

View reviewed changes

atlowChemi approved these changes Sep 8, 2024

View reviewed changes

jasnell approved these changes Sep 8, 2024

View reviewed changes

avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024

cjihrig requested changes Sep 8, 2024

View reviewed changes

doc/api/test.md Outdated Show resolved Hide resolved

lib/internal/main/test_runner.js Outdated Show resolved Hide resolved

lib/internal/test_runner/harness.js Outdated Show resolved Hide resolved

avivkeller requested a review from cjihrig September 8, 2024 20:52

avivkeller force-pushed the report-coverage-thresholds branch 2 times, most recently from c411a61 to e157067 Compare September 8, 2024 20:54

test_runner: report coverage thresholds in test:coverage

be77741

avivkeller force-pushed the report-coverage-thresholds branch from e157067 to be77741 Compare September 8, 2024 20:54

jasnell approved these changes Sep 8, 2024

View reviewed changes

cjihrig approved these changes Sep 8, 2024

View reviewed changes

doc/api/test.md Outdated Show resolved Hide resolved

lib/internal/test_runner/test.js Outdated Show resolved Hide resolved

Update doc/api/test.md

f86abda

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 8, 2024

move to coverage.js

45db682

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 9, 2024

avivkeller removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Sep 10, 2024

cjihrig approved these changes Sep 13, 2024

View reviewed changes

cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 13, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024

nodejs-github-bot merged commit 99bbf80 into nodejs:main Sep 13, 2024

RafaelGSS mentioned this pull request Sep 16, 2024

v22.9.0 proposal #54966

Merged

cjihrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 17, 2024

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024

Uh oh!

test_runner: report coverage thresholds in test:coverage #54813

test_runner: report coverage thresholds in test:coverage #54813

Uh oh!

Conversation

avivkeller commented Sep 6, 2024

Uh oh!

nodejs-github-bot commented Sep 6, 2024

Uh oh!

codecov bot commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avivkeller commented Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2024

Uh oh!

nodejs-github-bot commented Sep 10, 2024

Uh oh!

avivkeller commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 13, 2024

Uh oh!

avivkeller commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 13, 2024

Uh oh!

avivkeller commented Sep 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

test_runner: report coverage thresholds in `test:coverage` #54813

test_runner: report coverage thresholds in `test:coverage` #54813

codecov bot commented Sep 6, 2024 •

edited

Loading

avivkeller commented Sep 7, 2024 •

edited

Loading

cjihrig left a comment •

edited

Loading

avivkeller commented Sep 13, 2024 •

edited

Loading