Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update NAN urls in ROADMAP.md and doc/releases.md #5472

Closed
wants to merge 1 commit into from

Conversation

ronkorving
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

ROADMAP.md

Description of change

Since NAN became an official Node.js project, its home moved from github.com/rvagg/nan to github.com/nodejs/nan. I've updated the NAN URLs in the roadmap document to reflect this. Nothing personal against @rvagg of course :)

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Feb 28, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Feb 28, 2016

LGTM

1 similar comment
@silverwind
Copy link
Contributor

LGTM

@ChALkeR
Copy link
Member

ChALkeR commented Feb 28, 2016

/doc/releases.md also has that link.

@ronkorving
Copy link
Contributor Author

Thanks for the notice, I'll update that too.

@ronkorving
Copy link
Contributor Author

@ChALkeR done

@ronkorving ronkorving changed the title doc: update NAN reference urls in ROADMAP.md doc: update NAN urls in ROADMAP.md and doc/releases.md Mar 2, 2016
@ChALkeR
Copy link
Member

ChALkeR commented Mar 2, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Mar 2, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 2, 2016

Landed in 0eda5f5

@jasnell jasnell closed this Mar 2, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants