Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add old issue stalebot #54672

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Aug 31, 2024

#52712 was an overly aggressive update to the stalebot, which would've lead to mass notifications being sent out to users.

This PR is a much more restrained version of that update. If an issue is older than 4 years and hasn't been updated in over 5 months, it will be marked as stale. This approach is similar to #48051 but focused on issues rather than PRs.

The 4-year threshold was chosen because it applies to only 257 issues, which seems like a manageable starting point.

Over time, I think we can unify the stalebots with the following steps:

  • (This PR) Integrate non-feature request issues into the slower stalebot process.
  • Gradually reduce the END_DATE to minimize disruption.
  • Once the END_DATE is down to 1 year, merge with close-stale-pull-requests.yml.
  • Once the END_DATE reaches 6 months, merge with close-stale-feature-requests.yml.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 31, 2024

CC @mhdawson


Also this may need TSC approval?

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 31, 2024
@RedYetiDev
Copy link
Member Author

(requesting your review as this modifies something that you gave some opinions on earlier)

@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants