test_runner: report failures in filtered suites #54387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the test runner's filter logic to handle test suite failures during the build phase. Prior to this commit, these suites were silently filtered.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
added
dont-land-on-v18.x
dont-land-on-v20.x
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54387 +/- ##
==========================================
- Coverage 87.09% 87.08% -0.01%
==========================================
Files 648 648
Lines 182250 182250
Branches 34967 34972 +5
==========================================
- Hits 158732 158720 -12
- Misses 16797 16802 +5
- Partials 6721 6728 +7
|
anonrig
approved these changes
Aug 15, 2024
MoLow
approved these changes
Aug 16, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
jakecastelli
approved these changes
Aug 17, 2024
Member
|
apparently |
Collaborator
benjamingr
approved these changes
Aug 18, 2024
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2226155 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
This commit updates the test runner's filter logic to handle test suite failures during the build phase. Prior to this commit, these suites were silently filtered. PR-URL: #54387 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
This commit updates the test runner's filter logic to handle test suite failures during the build phase. Prior to this commit, these suites were silently filtered. PR-URL: #54387 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner's filter logic to handle test suite failures during the build phase. Prior to this commit, these suites were silently filtered.