Fix duplicated test descriptions #54140
Open
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54140 +/- ##
==========================================
+ Coverage 87.06% 87.61% +0.54%
==========================================
Files 643 650 +7
Lines 181576 182834 +1258
Branches 34894 35383 +489
==========================================
+ Hits 158088 160183 +2095
+ Misses 16759 15924 -835
+ Partials 6729 6727 -2 |
aduh95
reviewed
Aug 1, 2024
lpinca
approved these changes
Aug 10, 2024
RedYetiDev
added
test
|
Hey @unseen1980. Just want to let you know the first commit is authored by @ckoutsiaris (just making sure this is intentional). Additionally, could you remove the trailing Thank you! |
unseen1980
force-pushed
the
duplicated-test-names
branch
from
89b21c0
to
70ce115
Compare
unseen1980
changed the title
Hi @RedYetiDev yes that is fine, same person :) I removed the |
|
Sorry I forgot to mention this earlier, but in order to land, the commit needs to be prefixed with a subsystem, followed by an active verb. For example, |
github-actions
bot
removed
the
request-ci
unseen1980
force-pushed
the
duplicated-test-names
branch
from
70ce115
to
1c293cb
Compare
github-actions
bot
removed
the
request-ci
aduh95
force-pushed
the
duplicated-test-names
branch
from
1c293cb
to
4e93a87
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
jakecastelli
added
the
commit-queue-squash
jakecastelli
approved these changes
Aug 24, 2024
marco-ippolito
added
the
commit-queue
marco-ippolito
approved these changes
Aug 28, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54140 ✔ Done loading data for nodejs/node/pull/54140 ----------------------------------- PR info ------------------------------------ Title Fix duplicated test descriptions (#54140) Author Christos Koutsiaris <koutsiaris@gmail.com> (@unseen1980, first-time contributor) Branch unseen1980:duplicated-test-names -> nodejs:main Labels test, author ready, needs-ci, commit-queue-squash, strip-types Commits 2 - test: remove duplicated test descriptions - fixup! test: remove duplicated test descriptions Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/54140 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54140 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 Jul 2024 11:00:48 GMT ✔ Approvals: 5 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2212768019 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54140#pullrequestreview-2231624173 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2238513235 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54140#pullrequestreview-2258732846 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2265320137 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-27T14:45:02Z: https://ci.nodejs.org/job/node-test-pull-request/61551/ - Querying data for job/node-test-pull-request/61551/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @unseen1980(koutsiaris@gmail.com) ⚠ - commit 4e93a87d4fef is authored by christos.koutsiaris@sap.com -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10591774472 |
|
I think the issue is that the commit email does not match the account email: |
Apologies for the mess, I just tried to amend the author of that commit. Not sure if it worked. |
jasnell
approved these changes
Aug 31, 2024
|
Can you squash commits into one and remove merge commits? |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
unseen1980
force-pushed
the
duplicated-test-names
branch
from
d05d9b5
to
94ee9b9
Compare
Hi @marco-ippolito it should be ok now, apologies for the messup. Thank you 👍 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
RedYetiDev
removed
the
commit-queue-failed
|
Hello, is there anything I need to do from my side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests had duplicate names. Please review these small changes.
Thanks
Christos