Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read #54044

Closed
wants to merge 2 commits into from
Closed

[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read #54044

wants to merge 2 commits into from

Conversation

MattiasBuelens
Copy link
Contributor

Manual backport of #50888 to v20.x.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jul 25, 2024
@MattiasBuelens
stream: implement min option for ReadableStreamBYOBReader.read
22340d9 
PR-URL: nodejs#50888
Backport-PR-URL: nodejs#54044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60627/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60642/

mcollina
mcollina approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattiasBuelens MattiasBuelens added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2024
@MattiasBuelens MattiasBuelens self-assigned this Jul 27, 2024
@MattiasBuelens MattiasBuelens removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2024
@mcollina
Copy link
Member

mcollina commented Aug 2, 2024

cc @nodejs/releasers @RafaelGSS can you include this in the next v20?

@MattiasBuelens MattiasBuelens added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 2, 2024
@mcollina mcollina added the lts-watch-v20.x PRs that may need to be released in v20.x label Aug 2, 2024
RafaelGSS
RafaelGSS approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

doc/api/webstreams.md Show resolved Hide resolved
@RafaelGSS
Copy link
Member

cc @nodejs/releasers @RafaelGSS can you include this in the next v20?

Yes, whoever takes the lead on the next v20 release will merge this PR with staging.

marco-ippolito pushed a commit that referenced this pull request Aug 8, 2024
@MattiasBuelens @marco-ippolito
stream: implement min option for ReadableStreamBYOBReader.read
4a3ecbf 
PR-URL: #50888
Backport-PR-URL: #54044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito
Copy link
Member

Landed in 4a3ecbf

@MattiasBuelens MattiasBuelens deleted the backport-50888-to-v20.x branch August 8, 2024 17:09
@targos targos removed the lts-watch-v20.x PRs that may need to be released in v20.x label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aymen94 aymen94 aymen94 approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees

@MattiasBuelens MattiasBuelens

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MattiasBuelens @nodejs-github-bot @mcollina @RafaelGSS @marco-ippolito @benjamingr @aymen94 @targos