Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: accept no arguments to start() #5388

Merged
merged 1 commit into from
Feb 25, 2016
Merged

repl: accept no arguments to start() #5388

merged 1 commit into from
Feb 25, 2016

Commits on Feb 25, 2016

  1. repl: accept no arguments to start()

    Currently, there is a check to ensure that the user either
    provides an object or a string to repl.start(). The string case
    is used to set a REPL prompt. However, a default of '> ' already
    exists, so forcing the user to specify a prompt is a bit
    redundant. This commit removes this restriction.
    
    Fixes: nodejs#5385
    PR-URL: nodejs#5388
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Julian Duque <julianduquej@gmail.com>
    cjihrig committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    ee7754b View commit details
    Browse the repository at this point in the history