tools: move ESLint to tools/eslint by targos · Pull Request #53413 · nodejs/node

targos · 2024-06-11T07:13:19Z

Greatly simplify how ESLint and its plugins are installed.

nodejs-github-bot · 2024-06-11T07:13:24Z

Review requested:

@nodejs/actions
@nodejs/startup
@nodejs/tsc

targos · 2024-06-11T07:14:17Z

Note that inikulin/dmn#56 is necessary to make the update script work correctly. I don't know if we should block this PR on it.

Greatly simplify how ESLint and its plugins are installed.

targos · 2024-06-11T07:17:27Z

I split the commit in two so the non-automated changes can be reviewed.

targos · 2024-06-11T07:41:14Z

I don't know why it adds >2000 new lines and what would be a good way to know it.

aduh95 · 2024-06-11T07:45:51Z

I don't know why it adds >2000 new lines and what would be a good way to know it.

git show f917d220363ff0fbb479e18b7ef9176e76d373de --diff-filter=A maybe?

targos · 2024-06-11T10:46:26Z

Forget about my previous comment. I did the analysis on another commit.

targos · 2024-06-11T10:56:32Z

I downgraded browserslist and caniuse-lite so they're at the same version as the main branch to reduce the changes.

targos · 2024-06-11T10:57:37Z

Now we don't have too many added files:

$ git show eb0f9bcde1cad9fb76d2509162ce06c89bb54a93 --diff-filter=A | grep "+++ b"
+++ b/tools/eslint/node_modules/eslint/node_modules/escape-string-regexp/index.js
+++ b/tools/eslint/node_modules/eslint/node_modules/escape-string-regexp/package.json
+++ b/tools/eslint/node_modules/eslint/node_modules/escape-string-regexp/readme.md
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/LICENSE
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/dist/eslint-visitor-keys.cjs
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/dist/eslint-visitor-keys.d.cts
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/lib/index.js
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/lib/visitor-keys.js
+++ b/tools/eslint/node_modules/eslint/node_modules/eslint-visitor-keys/package.json
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/LICENSE
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/dist/eslint-visitor-keys.cjs
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/dist/eslint-visitor-keys.d.cts
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/lib/index.js
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/lib/visitor-keys.js
+++ b/tools/eslint/node_modules/espree/node_modules/eslint-visitor-keys/package.json
+++ b/tools/eslint/node_modules/esquery/node_modules/estraverse/estraverse.js
+++ b/tools/eslint/node_modules/esquery/node_modules/estraverse/package.json
+++ b/tools/eslint/node_modules/esrecurse/node_modules/estraverse/estraverse.js
+++ b/tools/eslint/node_modules/esrecurse/node_modules/estraverse/package.json
+++ b/tools/eslint/node_modules/estraverse/LICENSE.BSD
+++ b/tools/eslint/node_modules/esutils/LICENSE.BSD
+++ b/tools/eslint/node_modules/yocto-queue/license

targos · 2024-06-13T09:51:08Z

/cc @nodejs/linting

aduh95 · 2024-06-13T10:28:31Z

Now we don't have too many added files:
$ git show eb0f9bcde1cad9fb76d2509162ce06c89bb54a93 --diff-filter=A | grep "+++ b"

note: you can use --name-only to ask git to show you only the name of files, instead of greping the whole diff

tools/dep_updaters/update-eslint.sh

aduh95 · 2024-06-13T10:35:56Z

tools/eslint/package-lock.json

Do we want to commit this file?

I would like to keep it for two reasons:

It allows to review what happened when an update PR is opened.

It will be possible to recover the exact dependency tree from the released tarball.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95

34f3770 LGTM, RSLGTM for the whole diff

nodejs-github-bot · 2024-06-17T10:38:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59834/

nodejs-github-bot · 2024-06-18T05:13:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59852/

nodejs-github-bot · 2024-06-18T09:07:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59855/

nodejs-github-bot · 2024-06-19T06:26:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59877/

nodejs-github-bot · 2024-06-19T11:49:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59884/

nodejs-github-bot · 2024-06-19T15:57:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59890/

nodejs-github-bot · 2024-06-19T19:54:10Z

Landed in 2eff28f

Greatly simplify how ESLint and its plugins are installed. PR-URL: #53413 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Greatly simplify how ESLint and its plugins are installed. PR-URL: nodejs#53413 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 11, 2024

tools: move ESLint to tools/eslint

34f3770

Greatly simplify how ESLint and its plugins are installed.

targos force-pushed the mv-eslint branch from 62e2c41 to f917d22 Compare June 11, 2024 07:16

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 11, 2024

This comment was marked as off-topic.

Sign in to view

squash: move eslint

eb0f9bc

targos force-pushed the mv-eslint branch from f917d22 to eb0f9bc Compare June 11, 2024 10:55

aduh95 reviewed Jun 13, 2024

View reviewed changes

tools/dep_updaters/update-eslint.sh Outdated Show resolved Hide resolved

aduh95 reviewed Jun 13, 2024

View reviewed changes

tools/dep_updaters/update-eslint.sh Outdated Show resolved Hide resolved

aduh95 reviewed Jun 13, 2024

View reviewed changes

targos and others added 2 commits June 13, 2024 12:43

Update tools/dep_updaters/update-eslint.sh

aee0711

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Update tools/dep_updaters/update-eslint.sh

24ca9f4

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Jun 16, 2024

tools: update eslint to 9.5.0 #53469

Closed

Update dmn

a67cb5a

aduh95 approved these changes Jun 17, 2024

View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2024

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024

nodejs-github-bot merged commit 2eff28f into nodejs:main Jun 19, 2024

targos deleted the mv-eslint branch June 19, 2024 19:54

targos added a commit that referenced this pull request Jun 20, 2024

tools: move ESLint to tools/eslint

30fdd48

Greatly simplify how ESLint and its plugins are installed. PR-URL: #53413 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024

tools: move ESLint to tools/eslint

ba99a3b

Greatly simplify how ESLint and its plugins are installed. PR-URL: nodejs#53413 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024

tools: move ESLint to tools/eslint

c98f029

Greatly simplify how ESLint and its plugins are installed. PR-URL: nodejs#53413 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Jun 25, 2024

v22.4.0 release proposal #53583

Merged

Karliz24 mentioned this pull request Jul 9, 2024

## 2024-07-02, Version 22.4.0 (Current), @targos Karliz24/Marley-#16

Open

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 19, 2024

Uh oh!

Conversation

targos commented Jun 11, 2024

Uh oh!

nodejs-github-bot commented Jun 11, 2024

Uh oh!

targos commented Jun 11, 2024

Uh oh!

targos commented Jun 11, 2024

Uh oh!

targos commented Jun 11, 2024

Uh oh!

aduh95 commented Jun 11, 2024

Uh oh!

This comment was marked as off-topic.

targos commented Jun 11, 2024

Uh oh!

targos commented Jun 11, 2024

Uh oh!

targos commented Jun 11, 2024

Uh oh!

targos commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

aduh95 Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

targos Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 17, 2024

Uh oh!

nodejs-github-bot commented Jun 18, 2024

Uh oh!

nodejs-github-bot commented Jun 18, 2024

Uh oh!

nodejs-github-bot commented Jun 19, 2024

Uh oh!

nodejs-github-bot commented Jun 19, 2024

Uh oh!

nodejs-github-bot commented Jun 19, 2024

Uh oh!

nodejs-github-bot commented Jun 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

targos commented Jun 13, 2024 •

edited

Loading