stream: make sure _destroy is called on the tail by jakecastelli · Pull Request #53213 · nodejs/node

jakecastelli · 2024-05-30T08:05:30Z

Fixes: #51987 (attempt to).

Please let me know if I am on the right track as I could be missing some important stuff here. If the fix is on the right track I will add a test.

EDIT: I have added a test.

nodejs-github-bot · 2024-05-30T08:05:35Z

Review requested:

@nodejs/streams

ronag · 2024-05-30T08:13:15Z

Do you think you could make a test?

ronag · 2024-05-30T16:21:38Z

I will have a look as soon as I have time

lib/internal/streams/compose.js

ronag · 2024-05-30T20:55:08Z

Good find and fix!

nodejs-github-bot · 2024-05-30T21:03:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59552/

Co-authored-by: Robert Nagy <ronagy@icloud.com>

mcollina

lgtm

nodejs-github-bot · 2024-05-31T14:46:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59570/

nodejs-github-bot · 2024-06-04T07:51:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59647/

mcollina

Can you avoid the use of timeouts in the test? They are usually pretty brittle to maintain.

test/parallel/test-stream-compose.js

jakecastelli · 2024-06-04T11:23:57Z

Can you avoid the use of timeouts in the test? They are usually pretty brittle to maintain.

Do you mean avoiding using setTimeout? maybe I can use setImmediate or process.nextTick instead?

jakecastelli · 2024-06-04T14:16:35Z

@mcollina I had a deeper look, I think I understood what you mean, the issue here is that _destroy is not called on the tail stream node, no matter if its a slow process or not.

I have removed the timeouts as they are not needed.

Although a quick question - does setImmediate usually cause less issue?

mcollina · 2024-06-04T15:26:17Z

Yes, it's more predictable.

jakecastelli · 2024-06-06T00:43:25Z

since the test has changed, shall we kick start another CI? 👀

nodejs-github-bot · 2024-06-08T15:47:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59699/

nodejs-github-bot · 2024-06-10T13:56:39Z

Commit Queue failed

- Loading data for nodejs/node/pull/53213
✔  Done loading data for nodejs/node/pull/53213
----------------------------------- PR info ------------------------------------
Title      stream: make sure _destroy is called on the tail (#53213)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jakecastelli:fix-51987 -> nodejs:main
Labels     author ready, needs-ci
Commits    5
 - stream: make sure _destroy is called
 - fixup! add test
 - Update lib/internal/streams/compose.js
 - fixup! use common.platformTimeout
 - fixup! remove slow process as its not needed
Committers 2
 - jakecastelli <959672929@qq.com>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53213
Fixes: https://github.com/nodejs/node/issues/51987
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53213
Fixes: https://github.com/nodejs/node/issues/51987
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup! use common.platformTimeout
   ⚠  - fixup! remove slow process as its not needed
   ℹ  This PR was created on Thu, 30 May 2024 08:05:30 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2089357194
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2091025829
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2094796152
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-06-08T15:47:51Z: https://ci.nodejs.org/job/node-test-pull-request/59699/
- Querying data for job/node-test-pull-request/59699/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/9449666312

mcollina

lgtm

nodejs-github-bot · 2024-06-10T14:47:49Z

Commit Queue failed

- Loading data for nodejs/node/pull/53213 ✔ Done loading data for nodejs/node/pull/53213 ----------------------------------- PR info ------------------------------------ Title stream: make sure _destroy is called on the tail (#53213) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-51987 -> nodejs:main Labels author ready, needs-ci Commits 5 - stream: make sure _destroy is called - fixup! add test - Update lib/internal/streams/compose.js - fixup! use common.platformTimeout - fixup! remove slow process as its not needed Committers 2 - jakecastelli <959672929@qq.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 30 May 2024 08:05:30 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2089357194 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2107988745 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2094796152 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-10T13:56:39Z: https://ci.nodejs.org/job/node-test-pull-request/59699/ - Querying data for job/node-test-pull-request/59699/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53213 From https://github.com/nodejs/node * branch refs/pull/53213/merge -> FETCH_HEAD ✔ Fetched commits as 2dea6a4520b8..d8a6156f7cb8 -------------------------------------------------------------------------------- [main 707c3ff394] stream: make sure _destroy is called Author: jakecastelli <959672929@qq.com> Date: Thu May 30 17:21:15 2024 +0930 1 file changed, 3 insertions(+), 3 deletions(-) [main 2dc4090f69] fixup! add test Author: jakecastelli <959672929@qq.com> Date: Thu May 30 22:54:57 2024 +0930 1 file changed, 49 insertions(+) [main 7866fd2a22] Update lib/internal/streams/compose.js Author: jakecastelli <38635403+jakecastelli@users.noreply.github.com> Date: Fri May 31 08:55:59 2024 +0930 1 file changed, 2 insertions(+), 1 deletion(-) [main 008624d2da] fixup! use common.platformTimeout Author: jakecastelli <959672929@qq.com> Date: Tue Jun 4 20:49:49 2024 +0930 1 file changed, 2 insertions(+), 2 deletions(-) [main 5e225afa4d] fixup! remove slow process as its not needed Author: jakecastelli <959672929@qq.com> Date: Tue Jun 4 23:44:27 2024 +0930 1 file changed, 13 insertions(+), 17 deletions(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: make sure _destroy is called

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD 2d4a067242] stream: make sure _destroy is called
Author: jakecastelli 959672929@qq.com
Date: Thu May 30 17:21:15 2024 +0930
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/10)
Rebasing (4/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! add test

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD 20581668fb] fixup! add test
Author: jakecastelli 959672929@qq.com
Date: Thu May 30 22:54:57 2024 +0930
1 file changed, 49 insertions(+)
Rebasing (5/10)
Rebasing (6/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/internal/streams/compose.js

Co-authored-by: Robert Nagy ronagy@icloud.com
PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD f51b69502a] Update lib/internal/streams/compose.js
Author: jakecastelli 38635403+jakecastelli@users.noreply.github.com
Date: Fri May 31 08:55:59 2024 +0930
1 file changed, 2 insertions(+), 1 deletion(-)
Rebasing (7/10)
Rebasing (8/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! use common.platformTimeout

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD a3ef6ef184] fixup! use common.platformTimeout
Author: jakecastelli 959672929@qq.com
Date: Tue Jun 4 20:49:49 2024 +0930
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (9/10)
Rebasing (10/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! remove slow process as its not needed

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD 023c600074] fixup! remove slow process as its not needed
Author: jakecastelli 959672929@qq.com
Date: Tue Jun 4 23:44:27 2024 +0930
1 file changed, 13 insertions(+), 17 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9450518114

nodejs-github-bot · 2024-06-10T14:56:06Z

Landed in 8e6901a

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#53213 Fixes: nodejs#51987 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

stream: make sure _destroy is called

a20e854

jakecastelli marked this pull request as ready for review May 30, 2024 08:05

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 30, 2024

fixup! add test

c731f78

ronag reviewed May 30, 2024

View reviewed changes

lib/internal/streams/compose.js Outdated Show resolved Hide resolved

ronag approved these changes May 30, 2024

View reviewed changes

ronag requested a review from mcollina May 30, 2024 20:54

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024

Update lib/internal/streams/compose.js

5d93185

Co-authored-by: Robert Nagy <ronagy@icloud.com>

ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2024

mcollina approved these changes May 31, 2024

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024

benjamingr approved these changes Jun 3, 2024

View reviewed changes

mcollina reviewed Jun 4, 2024

View reviewed changes

test/parallel/test-stream-compose.js Outdated Show resolved Hide resolved

fixup! use common.platformTimeout

cdea1dd

fixup! remove slow process as its not needed

d8a6156

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2024

mcollina approved these changes Jun 10, 2024

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 10, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024

nodejs-github-bot merged commit 8e6901a into nodejs:main Jun 10, 2024

targos mentioned this pull request Jun 25, 2024

v22.4.0 release proposal #53583

Merged

Karliz24 mentioned this pull request Jul 9, 2024

## 2024-07-02, Version 22.4.0 (Current), @targos Karliz24/Marley-#16

Open

marco-ippolito mentioned this pull request Jul 19, 2024

v20.16.0 proposal #53945

Merged

Uh oh!

Conversation

jakecastelli commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 30, 2024

Uh oh!

ronag commented May 30, 2024

Uh oh!

ronag commented May 30, 2024

Uh oh!

Uh oh!

ronag commented May 30, 2024

Uh oh!

nodejs-github-bot commented May 30, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 31, 2024

Uh oh!

nodejs-github-bot commented Jun 4, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakecastelli commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakecastelli commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina commented Jun 4, 2024

Uh oh!

jakecastelli commented Jun 6, 2024

Uh oh!

nodejs-github-bot commented Jun 8, 2024

Uh oh!

nodejs-github-bot commented Jun 10, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 10, 2024

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Co-authored-by: Robert Nagy ronagy@icloud.com PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Jun 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakecastelli commented May 30, 2024 •

edited

Loading

jakecastelli commented Jun 4, 2024 •

edited

Loading

jakecastelli commented Jun 4, 2024 •

edited

Loading

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Co-authored-by: Robert Nagy ronagy@icloud.com
PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com