Skip to content

Conversation

@theoludwig
Copy link
Contributor

@theoludwig theoludwig commented May 23, 2024

Fixes #44598 (was annoyed by the stale bot 😆)

It seems like, it is only marking them as stable in the documentation. Is it intended that these functions doesn't contain emitExperimentalWarning calls?

Fixes: #44598

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 23, 2024
@theoludwig theoludwig marked this pull request as ready for review May 23, 2024 22:21
@theoludwig theoludwig marked this pull request as draft May 23, 2024 22:28
@theoludwig theoludwig marked this pull request as ready for review May 23, 2024 22:33
@targos
Copy link
Member

targos commented May 24, 2024

@nodejs/fs

@aduh95 aduh95 added notable-change PRs with changes that should be highlighted in changelogs. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 26, 2024
@github-actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @aduh95.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@aduh95 aduh95 merged commit ff659fa into nodejs:main May 26, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 26, 2024

Landed in ff659fa

@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
@marco-ippolito marco-ippolito added the baking-for-lts PRs that need to wait before landing in a LTS release. label Jul 19, 2024
@aduh95 aduh95 removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize fs.cp(), fs.cpSync(), fsPromises.cp() methods

8 participants