-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
[v20.x backport] streams: fixes for webstreams #52773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v20.x backport] streams: fixes for webstreams #52773
Conversation
|
Review requested:
|
43c8f92 to
a7758ee
Compare
|
can you fix the conflicts? I'll try to backport it in the next v20 release |
a7758ee to
c6f0199
Compare
|
@marco-ippolito Updated and ready for review. 😉 |
|
Hi @MattiasBuelens I was backporting your commits, I encountered some issue, can you please cherry-pick the landed commits from the original PR (example #51168 (comment)), instead of the commits from your fork, so that they contain metadata like PR-URL and reviewers, and please squash the fixup commits |
a924e20 to
473fa73
Compare
c6f0199 to
773f990
Compare
PR-URL: nodejs#51168 Backport-PR-URL: nodejs#52773 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
773f990 to
573f5df
Compare
|
@marco-ippolito I've squashed the commits on this PR and rebased them onto The original PR didn't have the most prominent change in the first commit, so we landed it in 20c6313 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay. |
You can just cherry-pick the landed commits from the original PR (at the end of the pr in the comment from the bot landed in ...) and squash only the fixup commits |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Landed in 48138af |
Manual backport of #51168 to v20.x.
Depends on #52772, so keeping this in draft until that one lands.
This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞