lib,src: remove --experimental-policy #52583

RafaelGSS · 2024-04-18T20:59:54Z

Summary: We are dropping the --experimental-policy feature from Node.js.

nodejs-github-bot · 2024-04-18T20:59:59Z

Review requested:

@nodejs/loaders
@nodejs/security-wg
@nodejs/startup

lib/internal/modules/run_main.js

benjamingr

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

richardlau · 2024-04-19T12:04:45Z

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

We should doc deprecate it immediately -- even if it's not a requirement for experimental features to go through a full deprecation cycle the earlier we inform users that the feature is going away the better.

MoLow · 2024-04-19T12:20:55Z

added to tsc-agenda Issues and PRs to discuss during the meetings of the TSC. just for awareness

lib/internal/process/pre_execution.js

RafaelGSS · 2024-04-19T19:26:24Z

This is now ready to review. I'm adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here's the plan:

I'll open a new PR to update the doc to doc-deprecated
Merge that PR
Land doc-deprecation in all release lines
Merge this PR
Land this PR in all release lines

doc/api/errors.md

GeoffreyBooth · 2024-04-19T22:49:19Z

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.

richardlau · 2024-04-19T23:00:03Z

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.

We have in the past: #12243
I don't believe it is a requirement for experimental features to go through a full deprecation cycle, but that doesn't stop us doc-deprecating things. For example, I'd be much more hesitant to backport this PR (with 89 touched files) to LTS immediately -- I'd probably want to wait longer than the usual "two weeks in current" policy just due to the number of files touched whereas I'd have no issue with landing doc deprecations in line with the two week policy.

GeoffreyBooth · 2024-04-20T02:07:42Z

I think it's less disruptive to remove this as part of 22.0.0 than later in the 22 line, or in 23.

avivkeller · 2024-04-20T14:10:00Z

This is more of a meta note, but if we remove the experimental policy, we should also remove the issue label (policy) as well.

joyeecheung · 2024-04-20T14:49:18Z

Can we fast-track a doc-deprecation in 22? Maybe changing the experimental warning into deprecation warning too if that's not too much hassle? Then we can proceed with this PR for later versions of 22, or 23.

EDIT: oh I see #52602 now

RafaelGSS · 2024-04-22T18:56:42Z

doc-deprecation has been merged. I will wait for it to land on v22/v21 then I will proceed with this PR as it will hard conflict if I just merge it with dont-land-*.

github-actions · 2024-05-06T22:23:46Z

Failed to start CI

   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/8976580157

nodejs-github-bot · 2024-05-06T23:04:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58994/

nodejs-github-bot · 2024-05-07T04:18:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59003/

nodejs-github-bot · 2024-05-07T07:59:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59006/

nodejs-github-bot · 2024-05-07T16:25:47Z

Landed in 951af83

avivkeller · 2024-05-07T16:28:04Z

The policy label should also be removed from the issue tracker

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#52583 Refs: nodejs#52575 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #52583 Refs: #52575 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: doc: * add pimterry to collaborators (Tim Perry) #52874 lib,src: * remove --experimental-policy (Rafael Gonzaga) #52583 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: TODO

Notable changes: cli: * (SEMVER-MINOR) allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) #52766 doc: * add pimterry to collaborators (Tim Perry) #52874 fs: * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs (Aviv Keller) #52837 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) #52734 lib,src: * remove --experimental-policy (Rafael Gonzaga) #52583 perf_hooks: * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields (Matthew Aitken) #51589 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) #52860 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: #52971

marco-ippolito · 2024-06-17T08:31:05Z

Do we want to backport it to v20?

RafaelGSS · 2024-06-17T11:56:46Z

Do we want to backport it to v20?

Yes

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#52583 Refs: nodejs#52575 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: cli: * (SEMVER-MINOR) allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) nodejs#52766 doc: * add pimterry to collaborators (Tim Perry) nodejs#52874 fs: * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs (Aviv Keller) nodejs#52837 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) nodejs#52734 lib,src: * remove --experimental-policy (Rafael Gonzaga) nodejs#52583 perf_hooks: * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields (Matthew Aitken) nodejs#51589 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) nodejs#52860 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) nodejs#52692 PR-URL: nodejs#52971

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#52583 Refs: nodejs#52575 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: cli: * (SEMVER-MINOR) allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) nodejs#52766 doc: * add pimterry to collaborators (Tim Perry) nodejs#52874 fs: * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs (Aviv Keller) nodejs#52837 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) nodejs#52734 lib,src: * remove --experimental-policy (Rafael Gonzaga) nodejs#52583 perf_hooks: * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields (Matthew Aitken) nodejs#51589 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) nodejs#52860 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) nodejs#52692 PR-URL: nodejs#52971

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 18, 2024

anonrig approved these changes Apr 18, 2024

View reviewed changes

lib/internal/modules/run_main.js Outdated Show resolved Hide resolved

benjamingr reviewed Apr 19, 2024

View reviewed changes

MoLow added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 19, 2024

MoLow reviewed Apr 19, 2024

View reviewed changes

lib/internal/process/pre_execution.js Show resolved Hide resolved

RafaelGSS force-pushed the drop-experimental-policy branch 3 times, most recently from e0004d1 to f4a190e Compare April 19, 2024 19:24

RafaelGSS marked this pull request as ready for review April 19, 2024 19:24

RafaelGSS mentioned this pull request Apr 19, 2024

doc: deprecate --experimental-policy #52602

Closed

aduh95 reviewed Apr 19, 2024

View reviewed changes

doc/api/errors.md Show resolved Hide resolved

RafaelGSS force-pushed the drop-experimental-policy branch from f4a190e to 077fd72 Compare April 19, 2024 20:15

GeoffreyBooth approved these changes Apr 19, 2024

View reviewed changes

GeoffreyBooth removed the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Apr 19, 2024

mhdawson mentioned this pull request Apr 22, 2024

Node.js Technical Steering Committee (TSC) Meeting 2024-04-24 nodejs/TSC#1535

Closed

github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 6, 2024

MoLow approved these changes May 7, 2024

View reviewed changes

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 7, 2024

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024

marco-ippolito approved these changes May 7, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024

nodejs-github-bot merged commit 951af83 into nodejs:main May 7, 2024
59 checks passed

RafaelGSS mentioned this pull request May 7, 2024

Remove --experimental-policy #52575

Closed

targos mentioned this pull request May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 19, 2024

RafaelGSS mentioned this pull request Aug 8, 2024

doc: remove module-based permission doc #54266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib,src: remove --experimental-policy #52583

lib,src: remove --experimental-policy #52583

RafaelGSS commented Apr 18, 2024 •

edited

Loading

nodejs-github-bot commented Apr 18, 2024

benjamingr left a comment •

edited

Loading

richardlau commented Apr 19, 2024

MoLow commented Apr 19, 2024

RafaelGSS commented Apr 19, 2024

GeoffreyBooth commented Apr 19, 2024

richardlau commented Apr 19, 2024

GeoffreyBooth commented Apr 20, 2024

avivkeller commented Apr 20, 2024

joyeecheung commented Apr 20, 2024 •

edited

Loading

RafaelGSS commented Apr 22, 2024

github-actions bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 7, 2024

nodejs-github-bot commented May 7, 2024

nodejs-github-bot commented May 7, 2024

avivkeller commented May 7, 2024

marco-ippolito commented Jun 17, 2024

RafaelGSS commented Jun 17, 2024

lib,src: remove --experimental-policy #52583

lib,src: remove --experimental-policy #52583

Conversation

RafaelGSS commented Apr 18, 2024 • edited Loading

nodejs-github-bot commented Apr 18, 2024

benjamingr left a comment • edited Loading

Choose a reason for hiding this comment

richardlau commented Apr 19, 2024

MoLow commented Apr 19, 2024

RafaelGSS commented Apr 19, 2024

GeoffreyBooth commented Apr 19, 2024

richardlau commented Apr 19, 2024

GeoffreyBooth commented Apr 20, 2024

avivkeller commented Apr 20, 2024

joyeecheung commented Apr 20, 2024 • edited Loading

RafaelGSS commented Apr 22, 2024

github-actions bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 7, 2024

nodejs-github-bot commented May 7, 2024

nodejs-github-bot commented May 7, 2024

avivkeller commented May 7, 2024

marco-ippolito commented Jun 17, 2024

RafaelGSS commented Jun 17, 2024

RafaelGSS commented Apr 18, 2024 •

edited

Loading

benjamingr left a comment •

edited

Loading

joyeecheung commented Apr 20, 2024 •

edited

Loading