doc: remove mold use on mac for speeding up build #52252

congzhangzh · 2024-03-28T14:13:38Z

As title, the the mold/sold does not fit for mac, so related info need be remove.

SuperchupuDev

some typos

BUILDING.md

congzhangzh · 2024-03-28T14:42:15Z

@H4ad @SuperchupuDev Hi folks, can you have a look?

congzhangzh · 2024-03-28T14:42:33Z

some typos

@SuperchupuDev tks for you quick reply:)

congzhangzh · 2024-03-30T13:12:24Z

@H4ad @anonrig @SuperchupuDev Hi folks, can you merge this pr, as all check seems passed :)

congzhangzh · 2024-03-30T13:12:57Z

I have some more pr related to building, so hope this be done first

SuperchupuDev · 2024-03-30T13:15:26Z

i am not part of node, in fact i did my first contribution to node last week, but if it has the commit queue label it will be merged automatically once enough time passes i think? (i think its after two days of pr creation)

congzhangzh · 2024-03-30T13:23:27Z

i am not part of node, in fact i did my first contribution to node last week, but if it has the commit queue label it will be merged automatically once enough time passes i think? (i think its after two days of pr creation)

@SuperchupuDev thanks for the tips:)

nodejs-github-bot · 2024-03-30T14:21:15Z

Commit Queue failed

- Loading data for nodejs/node/pull/52252
✔  Done loading data for nodejs/node/pull/52252
----------------------------------- PR info ------------------------------------
Title      doc: remove mold use on mac for speeding up build (#52252)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     congzhangzh:doc_building_fix_speed_up_section_4_mac -> nodejs:main
Labels     doc, build, commit-queue-squash
Commits    5
 - doc: remove mold use on mac for speeding up build
 - doc: fix 4 format-md
 - doc: Update BUILDING.md
 - doc: Update BUILDING.md
 - Merge branch 'nodejs:main' into doc_building_fix_speed_up_section_4_mac
Committers 2
 - GitHub 
 - Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/52252
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52252
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 28 Mar 2024 14:13:38 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52252#pullrequestreview-1966468616
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52252#pullrequestreview-1969679484
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52252
From https://github.com/nodejs/node
 * branch                  refs/pull/52252/merge -> FETCH_HEAD
✔  Fetched commits as 7c02486f1f91..0f632bf9e34a
--------------------------------------------------------------------------------
[main 8e33d1882e] doc: remove mold use on mac for speeding up build
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:10:49 2024 +0800
 1 file changed, 8 insertions(+), 7 deletions(-)
[main 7ec59e6d36] doc: fix 4 format-md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:36:40 2024 +0800
 1 file changed, 1 insertion(+)
[main 08ede74a13] doc: Update BUILDING.md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:41:14 2024 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
error: commit 0f632bf9e34a19a4646f27d92b0d43104be9fbfc is a merge but no -m option was given.
fatal: cherry-pick failed
[main 70c1a6d62c] doc: Update BUILDING.md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:41:25 2024 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/8491360975

congzhangzh · 2024-04-04T04:28:17Z

@H4ad Hi Vinicius, can you do a review? I do a rebase, as last auto merge failed, if it’s ok, tag this a commit queue:)

The main branch change quick, which trigger merge failed easily

BUILDING.md

nodejs-github-bot · 2024-04-04T12:50:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/52252
✔  Done loading data for nodejs/node/pull/52252
----------------------------------- PR info ------------------------------------
Title      doc: remove mold use on mac for speeding up build (#52252)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     congzhangzh:doc_building_fix_speed_up_section_4_mac -> nodejs:main
Labels     doc, build, commit-queue-squash
Commits    8
 - doc: remove mold use on mac for speeding up build
 - doc: fix 4 format-md
 - doc: Update BUILDING.md
 - doc: Update BUILDING.md
 - Merge branch 'nodejs:main' into doc_building_fix_speed_up_section_4_mac
 - Merge branch 'nodejs:main' into doc_building_fix_speed_up_section_4_mac
 - Merge branch 'nodejs:main' into doc_building_fix_speed_up_section_4_mac
 - doc: Update BUILDING.md
Committers 2
 - GitHub 
 - Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/52252
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52252
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 28 Mar 2024 14:13:38 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52252#pullrequestreview-1979732593
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52252#pullrequestreview-1969679484
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52252
From https://github.com/nodejs/node
 * branch                  refs/pull/52252/merge -> FETCH_HEAD
✔  Fetched commits as a63261cf2c77..19b64ca66f9f
--------------------------------------------------------------------------------
Auto-merging BUILDING.md
[main 49d8ec853c] doc: remove mold use on mac for speeding up build
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:10:49 2024 +0800
 1 file changed, 8 insertions(+), 7 deletions(-)
Auto-merging BUILDING.md
[main 63ee95e1f4] doc: fix 4 format-md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:36:40 2024 +0800
 1 file changed, 1 insertion(+)
Auto-merging BUILDING.md
[main e496dd806e] doc: Update BUILDING.md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:41:14 2024 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging BUILDING.md
error: commit 0f632bf9e34a19a4646f27d92b0d43104be9fbfc is a merge but no -m option was given.
fatal: cherry-pick failed
[main b7b9db82bd] doc: Update BUILDING.md
 Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com>
 Date: Thu Mar 28 22:41:25 2024 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/8554766295

H4ad · 2024-04-04T16:08:46Z

@congzhangzh Can you please squash all commits in one commit only, and remove the merge commits (basically rebase instead of merge)

nodejs-github-bot · 2024-04-06T15:31:47Z

Commit Queue failed

- Loading data for nodejs/node/pull/52252 ✔ Done loading data for nodejs/node/pull/52252 ----------------------------------- PR info ------------------------------------ Title doc: remove mold use on mac for speeding up build (#52252) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch congzhangzh:doc_building_fix_speed_up_section_4_mac -> nodejs:main Labels doc, build Commits 1 - doc: remove mold use on mac for speeding up build Committers 1 - Cong Zhang <13283869+congzhangzh@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Mar 2024 14:13:38 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52252#pullrequestreview-1983051981 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52252#pullrequestreview-1969679484 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52252 From https://github.com/nodejs/node * branch refs/pull/52252/merge -> FETCH_HEAD ✔ Fetched commits as 8c0b723ccb69..3592368f5480 -------------------------------------------------------------------------------- [main f6374c071e] doc: remove mold use on mac for speeding up build Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Thu Mar 28 22:10:49 2024 +0800 1 file changed, 10 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: remove mold use on mac for speeding up build

Co-authored-by: Vinicius Lourenço
12551007+H4ad@users.noreply.github.com

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[main d9a3d6c81d] doc: remove mold use on mac for speeding up build
Author: Cong Zhang 13283869+congzhangzh@users.noreply.github.com
Date: Thu Mar 28 22:10:49 2024 +0800
1 file changed, 10 insertions(+), 8 deletions(-)
✖ d9a3d6c81d0dc5d99a31529db11c511d4eb273c3
✖ 1:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 4:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/8582140212

H4ad · 2024-04-06T16:35:02Z

@anonrig any idea of what is missing to merge?

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com>

congzhangzh · 2024-04-07T13:27:50Z

@anonrig any idea of what is missing to merge?

@H4ad Hi, Vinícius, I think I fix it, the commit message of co-author need two empty line, but I provide only one, sorry for that

ref: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

nodejs-github-bot · 2024-04-10T23:45:29Z

Commit Queue failed

- Loading data for nodejs/node/pull/52252 ✔ Done loading data for nodejs/node/pull/52252 ----------------------------------- PR info ------------------------------------ Title doc: remove mold use on mac for speeding up build (#52252) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch congzhangzh:doc_building_fix_speed_up_section_4_mac -> nodejs:main Labels doc, build Commits 1 - doc: remove mold use on mac for speeding up build Committers 1 - Cong Zhang <13283869+congzhangzh@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Mar 2024 14:13:38 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52252#pullrequestreview-1983051981 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52252#pullrequestreview-1992856066 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52252 From https://github.com/nodejs/node * branch refs/pull/52252/merge -> FETCH_HEAD ✔ Fetched commits as 411503bacd68..d4881c072d19 -------------------------------------------------------------------------------- Auto-merging BUILDING.md [main ba42fec649] doc: remove mold use on mac for speeding up build Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Thu Mar 28 22:10:49 2024 +0800 1 file changed, 10 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: remove mold use on mac for speeding up build

Co-authored-by: Vinicius Lourenço
12551007+H4ad@users.noreply.github.com

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[main c2d9cdd388] doc: remove mold use on mac for speeding up build
Author: Cong Zhang 13283869+congzhangzh@users.noreply.github.com
Date: Thu Mar 28 22:10:49 2024 +0800
1 file changed, 10 insertions(+), 8 deletions(-)
✖ c2d9cdd388fbc531be2283f548152bf0f94cf1b7
✖ 1:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 4:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/8639243856

nodejs-github-bot · 2024-04-11T00:03:57Z

Commit Queue failed

- Loading data for nodejs/node/pull/52252 ✔ Done loading data for nodejs/node/pull/52252 ----------------------------------- PR info ------------------------------------ Title doc: remove mold use on mac for speeding up build (#52252) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch congzhangzh:doc_building_fix_speed_up_section_4_mac -> nodejs:main Labels doc, build Commits 1 - doc: remove mold use on mac for speeding up build Committers 1 - Cong Zhang <13283869+congzhangzh@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52252 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Mar 2024 14:13:38 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52252#pullrequestreview-1983051981 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52252#pullrequestreview-1992856066 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52252 From https://github.com/nodejs/node * branch refs/pull/52252/merge -> FETCH_HEAD ✔ Fetched commits as d32a914ac72a..d4881c072d19 -------------------------------------------------------------------------------- Auto-merging BUILDING.md [main 91249bc9b8] doc: remove mold use on mac for speeding up build Author: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Thu Mar 28 22:10:49 2024 +0800 1 file changed, 10 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: remove mold use on mac for speeding up build

Co-authored-by: Vinicius Lourenço
12551007+H4ad@users.noreply.github.com

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[main 31c5a96df7] doc: remove mold use on mac for speeding up build
Author: Cong Zhang 13283869+congzhangzh@users.noreply.github.com
Date: Thu Mar 28 22:10:49 2024 +0800
1 file changed, 10 insertions(+), 8 deletions(-)
✖ 31c5a96df7f1607258ce21c80017b9ed8421261c
✖ 1:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 4:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/8639364670

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com> PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

MoLow · 2024-04-30T13:28:46Z

Landed in d20515a

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com> PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com> PR-URL: nodejs#52252 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com> PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com> PR-URL: nodejs#52252 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 28, 2024

congzhangzh mentioned this pull request Mar 28, 2024

doc: add mold to speeding up section #52179

Merged

SuperchupuDev reviewed Mar 28, 2024

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

BUILDING.md Outdated Show resolved Hide resolved

congzhangzh marked this pull request as ready for review March 28, 2024 14:44

H4ad approved these changes Mar 28, 2024

View reviewed changes

anonrig approved these changes Mar 29, 2024

View reviewed changes

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 30, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 30, 2024

H4ad approved these changes Apr 4, 2024

View reviewed changes

H4ad requested changes Apr 4, 2024

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

H4ad removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 4, 2024

H4ad approved these changes Apr 4, 2024

View reviewed changes

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 4, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 4, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 6, 2024

anonrig approved these changes Apr 6, 2024

View reviewed changes

doc: remove mold use on mac for speeding up build

d4881c0

Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com>

congzhangzh force-pushed the doc_building_fix_speed_up_section_4_mac branch from 3592368 to d4881c0 Compare April 7, 2024 13:24

anonrig removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 10, 2024

anonrig approved these changes Apr 10, 2024

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 10, 2024

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 10, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 11, 2024

MoLow removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 30, 2024

MoLow approved these changes Apr 30, 2024

View reviewed changes

MoLow closed this Apr 30, 2024

aduh95 mentioned this pull request Apr 30, 2024

2024-05-02, Version 22.1.0 (Current) #52768

Merged

marco-ippolito mentioned this pull request May 23, 2024

v20.14.0 proposal #53120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: remove mold use on mac for speeding up build #52252

doc: remove mold use on mac for speeding up build #52252

congzhangzh commented Mar 28, 2024 •

edited by anonrig

Loading

SuperchupuDev left a comment

congzhangzh commented Mar 28, 2024

congzhangzh commented Mar 28, 2024 •

edited

Loading

congzhangzh commented Mar 30, 2024

congzhangzh commented Mar 30, 2024

SuperchupuDev commented Mar 30, 2024 •

edited

Loading

congzhangzh commented Mar 30, 2024

nodejs-github-bot commented Mar 30, 2024

congzhangzh commented Apr 4, 2024

nodejs-github-bot commented Apr 4, 2024

H4ad commented Apr 4, 2024

nodejs-github-bot commented Apr 6, 2024

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

H4ad commented Apr 6, 2024 •

edited

Loading

congzhangzh commented Apr 7, 2024 •

edited

Loading

nodejs-github-bot commented Apr 10, 2024

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

nodejs-github-bot commented Apr 11, 2024

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

MoLow commented Apr 30, 2024

doc: remove mold use on mac for speeding up build #52252

doc: remove mold use on mac for speeding up build #52252

Conversation

congzhangzh commented Mar 28, 2024 • edited by anonrig Loading

SuperchupuDev left a comment

Choose a reason for hiding this comment

congzhangzh commented Mar 28, 2024

congzhangzh commented Mar 28, 2024 • edited Loading

congzhangzh commented Mar 30, 2024

congzhangzh commented Mar 30, 2024

SuperchupuDev commented Mar 30, 2024 • edited Loading

congzhangzh commented Mar 30, 2024

nodejs-github-bot commented Mar 30, 2024

congzhangzh commented Apr 4, 2024

nodejs-github-bot commented Apr 4, 2024

H4ad commented Apr 4, 2024

nodejs-github-bot commented Apr 6, 2024

PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

H4ad commented Apr 6, 2024 • edited Loading

congzhangzh commented Apr 7, 2024 • edited Loading

nodejs-github-bot commented Apr 10, 2024

PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

nodejs-github-bot commented Apr 11, 2024

PR-URL: #52252 Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

MoLow commented Apr 30, 2024

congzhangzh commented Mar 28, 2024 •

edited by anonrig

Loading

congzhangzh commented Mar 28, 2024 •

edited

Loading

SuperchupuDev commented Mar 30, 2024 •

edited

Loading

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

H4ad commented Apr 6, 2024 •

edited

Loading

congzhangzh commented Apr 7, 2024 •

edited

Loading

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

PR-URL: #52252
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io