test_runner: skip each hooks for skipped tests #52115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test is skipped, the corresponding beforeEach and afterEach hooks should also be skipped. Fixes: nodejs#52112
|
Review requested:
|
nodejs-github-bot
added
needs-ci
rluvaton
approved these changes
Mar 16, 2024
|
Added more tests. |
atlowChemi
approved these changes
Mar 16, 2024
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
atlowChemi
approved these changes
Mar 17, 2024
github-actions
bot
removed
the
request-ci
atlowChemi
added
the
author ready
MoLow
approved these changes
Mar 17, 2024
cjihrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52115 ✔ Done loading data for nodejs/node/pull/52115 ----------------------------------- PR info ------------------------------------ Title test_runner: skip each hooks for skipped tests (#52115) Author Colin Ihrig (@cjihrig) Branch cjihrig:each-hooks -> nodejs:main Labels author ready, needs-ci, test_runner Commits 3 - test_runner: skip each hooks for skipped tests - additional tests - Update test/fixtures/test-runner/output/suite-skip-hooks.js Committers 2 - cjihrig - GitHub PR-URL: https://github.com/nodejs/node/pull/52115 Fixes: https://github.com/nodejs/node/issues/52112 Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52115 Fixes: https://github.com/nodejs/node/issues/52112 Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Mar 2024 16:13:58 GMT ✔ Approvals: 3 ✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/52115#pullrequestreview-1941189165 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/52115#pullrequestreview-1941388256 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52115#pullrequestreview-1941414647 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-17T07:13:58Z: https://ci.nodejs.org/job/node-test-pull-request/57786/ - Querying data for job/node-test-pull-request/57786/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52115 From https://github.com/nodejs/node * branch refs/pull/52115/merge -> FETCH_HEAD ✔ Fetched commits as 8a191e4e6a39..3d5934220ed7 -------------------------------------------------------------------------------- Auto-merging lib/internal/test_runner/test.js [main 3d705cbf9b] test_runner: skip each hooks for skipped tests Author: cjihrig Date: Sat Mar 16 12:12:44 2024 -0400 4 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 test/fixtures/test-runner/output/skip-each-hooks.js create mode 100644 test/fixtures/test-runner/output/skip-each-hooks.snapshot [main a567bd199f] additional tests Author: cjihrig Date: Sat Mar 16 13:32:22 2024 -0400 3 files changed, 101 insertions(+) create mode 100644 test/fixtures/test-runner/output/suite-skip-hooks.js create mode 100644 test/fixtures/test-runner/output/suite-skip-hooks.snapshot [main 8c4534e860] Update test/fixtures/test-runner/output/suite-skip-hooks.js Author: Colin Ihrig Date: Sat Mar 16 19:13:57 2024 -0400 1 file changed, 16 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/8329948090 |
MoLow
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6f4d601 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
When a test is skipped, the corresponding beforeEach and afterEach hooks should also be skipped. Fixes: nodejs#52112 PR-URL: nodejs#52115 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test is skipped, the corresponding beforeEach and afterEach hooks should also be skipped.
Fixes: #52112