Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add some commonly used labels up front #52006

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 7, 2024

From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc.

From the last onboarding session I think it would be
good to add two commonly used lables to the section
which is linked from the onboarding doc.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 7, 2024
@@ -879,9 +879,13 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help.

* `confirmed-bug`: Bugs you have verified
* `discuss`: Things that need larger discussion
* `fast-track`: PRs that need to land faster - see
Copy link
Member

@MoLow MoLow Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if putting fast-track PRs that do not need to wait for 48 hours to land. (i.e. https://github.com/nodejs/node/labels/fast-track) into the markdown will automatically get the color

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoLow are we getting the color or the others but not for these?

@sxa sxa changed the title doc: add some commonly used lables up gront doc: add some commonly used lables up front Mar 8, 2024
@sxa sxa changed the title doc: add some commonly used lables up front doc: add some commonly used labels up front Mar 8, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit e11c1d2 into nodejs:main Mar 9, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e11c1d2

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
From the last onboarding session I think it would be
good to add two commonly used lables to the section
which is linked from the onboarding doc.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
From the last onboarding session I think it would be
good to add two commonly used lables to the section
which is linked from the onboarding doc.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
From the last onboarding session I think it would be
good to add two commonly used lables to the section
which is linked from the onboarding doc.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.