Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-dgram-pingpong #5125

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-dgram-pingpong #5125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ prefix sequential

[$system==linux]
test-vm-syntax-error-stderr : PASS,FLAKY
test-dgram-pingpong : PASS,FLAKY
test-http-regr-gh-2928 : PASS,FLAKY

[$system==macos]
Expand Down
85 changes: 21 additions & 64 deletions test/sequential/test-dgram-pingpong.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,89 +1,46 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var Buffer = require('buffer').Buffer;
var dgram = require('dgram');

var debug = false;
var tests_run = 0;
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

function pingPongTest(port, host) {
var callbacks = 0;
var N = 500;
var count = 0;

var server = dgram.createSocket('udp4', function(msg, rinfo) {
if (debug) console.log('server got: ' + msg +
' from ' + rinfo.address + ':' + rinfo.port);

if (/PING/.exec(msg)) {
var buf = new Buffer(4);
buf.write('PONG');
server.send(buf, 0, buf.length,
rinfo.port, rinfo.address,
function(err, sent) {
callbacks++;
});
}
});
const server = dgram.createSocket('udp4', common.mustCall((msg, rinfo) => {
assert.strictEqual('PING', msg.toString('ascii'));
server.send('PONG', 0, 4, rinfo.port, rinfo.address);
}));

server.on('error', function(e) {
throw e;
});

server.on('listening', function() {
console.log('server listening on ' + port + ' ' + host);
console.log('server listening on ' + port);

const buf = new Buffer('PING');
const client = dgram.createSocket('udp4');

client.on('message', function(msg, rinfo) {
if (debug) console.log('client got: ' + msg +
' from ' + rinfo.address + ':' + rinfo.port);
assert.equal('PONG', msg.toString('ascii'));

count += 1;

if (count < N) {
client.send(buf, 0, buf.length, port, 'localhost');
} else {
client.send(buf, 0, buf.length, port, 'localhost', function() {
client.close();
});
}
});
client.on('message', function(msg) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the callback here should be wrapped with common.mustCall(..., N)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on it. I left it without common.mustCall() and used the assert.strictEqual(pongsReceived, N); instead so that it would be readily apparent that it's the analogous check to assert(pingsReceived >= N);.

assert.strictEqual('PONG', msg.toString('ascii'));

client.on('close', function() {
console.log('client has closed, closing server');
assert.equal(N, count);
tests_run += 1;
client.close();
server.close();
assert.equal(N - 1, callbacks);
});

client.on('error', function(e) {
throw e;
});

console.log('Client sending to ' + port + ', localhost ' + buf);
client.send(buf, 0, buf.length, port, 'localhost', function(err, bytes) {
if (err) {
throw err;
}
console.log('Client sent ' + bytes + ' bytes');
});
count += 1;
console.log('Client sending to ' + port);

function clientSend() {
client.send('PING', 0, 4, port, 'localhost');
}

clientSend();
});
server.bind(port, host);
return server;
}

// All are run at once, so run on different ports
pingPongTest(common.PORT + 0, 'localhost');
pingPongTest(common.PORT + 1, 'localhost');
pingPongTest(common.PORT + 2);
//pingPongTest('/tmp/pingpong.sock');

process.on('exit', function() {
assert.equal(3, tests_run);
console.log('done');
});
const server = pingPongTest(common.PORT, 'localhost');
server.on('close', common.mustCall(pingPongTest.bind(undefined, common.PORT)));