-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update doc to new version #51192
Conversation
Review requested:
|
I think this update should be split into several commits to prevent commit message lint failure |
This is blocked by micromark/micromark#157, see #49988 (comment) |
running a full CI cycle to check if this can get unblocked |
still failing
|
53c8f72
to
fe425f3
Compare
amended commit otherwise we will never land this, I'll fix the tool in another PR |
(The blocking PR has been closed) |
And the problem hasn't been addressed, the CI doesn't pass. |
d9f922a
to
226596e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51192 +/- ##
==========================================
- Coverage 88.42% 87.92% -0.50%
==========================================
Files 654 654
Lines 187852 187852
Branches 36134 35824 -310
==========================================
- Hits 166102 165167 -935
- Misses 14989 15875 +886
- Partials 6761 6810 +49 |
Commit Queue failed- Loading data for nodejs/node/pull/51192 ✔ Done loading data for nodejs/node/pull/51192 ----------------------------------- PR info ------------------------------------ Title tools: update doc to new version (#51192) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 2 - tools: disable doc building when ICU is not available - tools: update doc to new version Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tools: disable doc building when ICU is not available ⚠ - tools: update doc to new version ℹ This PR was created on Sun, 17 Dec 2023 00:26:43 GMT ✔ Approvals: 4 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2203485934 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2106067988 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2161903820 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/51192#pullrequestreview-2259349505 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-16T23:04:18Z: https://ci.nodejs.org/job/node-test-pull-request/63590/ - Querying data for job/node-test-pull-request/63590/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11878353074 |
Landed in b0051de...b1ee186 |
PR-URL: #51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This is an automated update of doc to new version.