Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update doc to new version #51192

Closed
wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 17, 2023

This is an automated update of doc to new version.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2023
@marco-ippolito
Copy link
Member

I think this update should be split into several commits to prevent commit message lint failure

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Dec 17, 2023
@aduh95
Copy link
Contributor

aduh95 commented Dec 17, 2023

This is blocked by micromark/micromark#157, see #49988 (comment)

@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 tools: update doc to remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.1.0 Jan 14, 2024
@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Feb 11, 2024
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2024
@MoLow
Copy link
Member

MoLow commented Apr 21, 2024

running a full CI cycle to check if this can get unblocked

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@MoLow
Copy link
Member

MoLow commented Apr 21, 2024

still failing

10:25:08 export const unicodePunctuation = regexCheck(/\p{P}|\p{S}/u);
10:25:08                                              ^^^^^^^^^^^^^^
10:25:08 
10:25:08 SyntaxError: Invalid regular expression: /\p{P}|\p{S}/u: Invalid property name
10:25:08     at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
10:25:08     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
10:25:08     at callTranslator (node:internal/modules/esm/loader:428:14)
10:25:08     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:434:30)

@marco-ippolito marco-ippolito force-pushed the actions/tools-update-doc branch from 53c8f72 to fe425f3 Compare May 8, 2024 09:58
@marco-ippolito
Copy link
Member

amended commit otherwise we will never land this, I'll fix the tool in another PR

@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.1.0 tools: update doc to new version May 12, 2024
@avivkeller avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Sep 24, 2024
@avivkeller
Copy link
Member

(The blocking PR has been closed)

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Sep 24, 2024
@aduh95
Copy link
Contributor

aduh95 commented Sep 24, 2024

(The blocking PR has been closed)

And the problem hasn't been addressed, the CI doesn't pass.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2024
@aduh95 aduh95 force-pushed the actions/tools-update-doc branch from d9f922a to 226596e Compare November 16, 2024 21:57
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Nov 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 16, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (b02cd41) to head (45e4f9c).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #51192      +/-   ##
==========================================
- Coverage   88.42%   87.92%   -0.50%     
==========================================
  Files         654      654              
  Lines      187852   187852              
  Branches    36134    35824     -310     
==========================================
- Hits       166102   165167     -935     
- Misses      14989    15875     +886     
- Partials     6761     6810      +49     

see 91 files with indirect coverage changes

@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. labels Nov 17, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/51192
✔  Done loading data for nodejs/node/pull/51192
----------------------------------- PR info ------------------------------------
Title      tools: update doc to new version (#51192)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-doc -> nodejs:main
Labels     doc, tools, author ready, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x
Commits    2
 - tools: disable doc building when ICU is not available
 - tools: update doc to new version
Committers 2
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
 - Node.js GitHub Bot <github-bot@iojs.org>
PR-URL: https://github.com/nodejs/node/pull/51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: disable doc building when ICU is not available
   ⚠  - tools: update doc to new version
   ℹ  This PR was created on Sun, 17 Dec 2023 00:26:43 GMT
   ✔  Approvals: 4
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2203485934
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2106067988
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2161903820
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/51192#pullrequestreview-2259349505
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-16T23:04:18Z: https://ci.nodejs.org/job/node-test-pull-request/63590/
- Querying data for job/node-test-pull-request/63590/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11878353074

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 17, 2024
@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Landed in b0051de...b1ee186

nodejs-github-bot pushed a commit that referenced this pull request Nov 17, 2024
PR-URL: #51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
nodejs-github-bot added a commit that referenced this pull request Nov 17, 2024
PR-URL: #51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
PR-URL: nodejs#51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
PR-URL: nodejs#51192
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants