doc: set exit code in custom test runner example#51056
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Dec 20, 2023
Merged
doc: set exit code in custom test runner example#51056nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
approved these changes
Dec 5, 2023
doc/api/test.md
Outdated
Comment on lines
1158
to
1159
| process.exitCode = 1 | ||
| }) |
Member
There was a problem hiding this comment.
Suggested change
| process.exitCode = 1 | |
| }) | |
| process.exitCode = 1; | |
| }) |
doc/api/test.md
Outdated
|
|
||
| run({ files: [path.resolve('./tests/test.js')] }) | ||
| .on('test:fail', () => { | ||
| process.exitCode = 1 |
Member
There was a problem hiding this comment.
Suggested change
| process.exitCode = 1 | |
| process.exitCode = 1; |
juliangruber
suggested changes
Dec 5, 2023
doc/api/test.md
Outdated
|
|
||
| run({ files: [path.resolve('./tests/test.js')] }) | ||
| .on('test:fail', () => { | ||
| process.exitCode = 1 |
Member
There was a problem hiding this comment.
Suggested change
| process.exitCode = 1 | |
| process.exitCode = 1; |
lpinca
approved these changes
Dec 5, 2023
Merged
8 tasks
jasnell
approved these changes
Dec 9, 2023
aymen94
approved these changes
Dec 13, 2023
mcollina
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
atlowChemi
approved these changes
Dec 20, 2023
atlowChemi
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c1051a0 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51056 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51056 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.