test: move to for of loop in test-http-hostname-typechecking.js#50782
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 22, 2023
Merged
Conversation
nodejs-github-bot
added
needs-ci
marco-ippolito
added
the
code-and-learn
Contributor
|
Could you please add the file name in the commit message? |
github-actions
bot
removed
the
request-ci
Collaborator
Puppo
force-pushed
the
refactor/test-http-hostname-typechecking
branch
from
664697b to
9cfac4a
Compare
Puppo
changed the title
Puppo
force-pushed
the
refactor/test-http-hostname-typechecking
branch
from
9cfac4a to
8aa4665
Compare
Contributor
Author
|
@ShogunPanda done ✅ |
Puppo
force-pushed
the
refactor/test-http-hostname-typechecking
branch
from
8aa4665 to
c4f84d6
Compare
Puppo
changed the title
RafaelGSS
approved these changes
Nov 24, 2023
github-actions
bot
removed
the
request-ci
Collaborator
debadree25
added
the
author ready
marco-ippolito
added
the
request-ci
marco-ippolito
approved these changes
Dec 21, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c9fe4b6 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #50782 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50782 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
your first node.js contribution workshop