Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use destructuring for accessing setting values #50609

Merged
merged 1 commit into from
Nov 11, 2023
Merged

test: use destructuring for accessing setting values #50609

merged 1 commit into from
Nov 11, 2023

Conversation

yedlosh
Copy link
Contributor

@yedlosh yedlosh commented Nov 7, 2023

  • Use destructuring in line 107 of test-http2-session-settings.js
  • Replaces index based access to the setting values
  • (nodeconfeu workshop)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55484/

This was referenced Nov 8, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/55540/ 💛

@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Open
27 tasks
jasnell
jasnell reviewed Nov 11, 2023
View reviewed changes
test/parallel/test-http2-session-settings.js
@@ -104,15 +104,15 @@ server.listen(
['maxHeaderListSize', 2 ** 32],
['maxHeaderSize', -1],
['maxHeaderSize', 2 ** 32],
].forEach((i) => {
].forEach(([key, value]) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but it would probably be worth changing this for a for (...) loop instead of forEach(...)

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5c500b7 into nodejs:main Nov 11, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5c500b7

targos pushed a commit that referenced this pull request Nov 11, 2023
@yedlosh @targos
test: use destructuring for accessing setting values
9181f70 
PR-URL: #50609
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@yedlosh @targos
test: use destructuring for accessing setting values
8be718a 
PR-URL: #50609
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@yedlosh @UlisesGascon
test: use destructuring for accessing setting values
a376284 
PR-URL: #50609
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yedlosh @nodejs-github-bot @jasnell @lpinca @anonrig @tniessen @marco-ippolito