benchmark: change iterations in benchmark/es/string-concatenations.js #50585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
H4ad
added
author ready
github-actions
bot
removed
the
request-ci
|
@H4ad I found that three checks failed. But I don't think my modifications should trigger these issues. Could you help me retrigger them? Thanks. |
It looks okay now. |
|
@Septa2112 is common, some checks can fail because of flaky tests. Now the PR will wait some hours until it gets merged automatically. |
Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: nodejs#50571
This was referenced Nov 8, 2023
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50585 ✔ Done loading data for nodejs/node/pull/50585 ----------------------------------- PR info ------------------------------------ Title benchmark: change iterations in benchmark/es/string-concatenations.js (#50585) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Septa2112:test-branch -> nodejs:main Labels v8 engine, benchmark, author ready Commits 1 - benchmark: change iterations in benchmark/es/string-concatenations.js Committers 1 - Jia Liu PR-URL: https://github.com/nodejs/node/pull/50585 Fixes: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50585 Fixes: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - benchmark: change iterations in benchmark/es/string-concatenations.js ℹ This PR was created on Tue, 07 Nov 2023 02:43:49 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50585#pullrequestreview-1716697270 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6806760384 |
debadree25
approved these changes
Nov 9, 2023
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bb2dd0e |
This was referenced Nov 10, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: #50571 PR-URL: #50585 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: #50571 PR-URL: #50585 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: #50571 PR-URL: #50585 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the number of iterations from
1e3to1e6to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations.Fixes: #50571