benchmark: update benchmark for URLSearchParams.sort #50568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
aduh95
reviewed
Nov 6, 2023
Comment on lines
20
to
24
| const out = []; | ||
| for (const key of str.split('&')) { | ||
| out.push(key, ''); | ||
| out.push(key); | ||
| } | ||
| return out; |
There was a problem hiding this comment.
Suggested change
| const out = []; | |
| for (const key of str.split('&')) { | |
| out.push(key, ''); | |
| out.push(key); | |
| } | |
| return out; | |
| return str.split('&'); |
kylo5aby
force-pushed
the
update-benchmark
branch
2 times, most recently
from
93667c2 to
28e4257
Compare
H4ad
approved these changes
Nov 8, 2023
H4ad
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50568 ✔ Done loading data for nodejs/node/pull/50568 ----------------------------------- PR info ------------------------------------ Title benchmark: update benchmark for URLSearchParams.sort (#50568) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zhenweijin:update-benchmark -> nodejs:main Labels url, benchmark, whatwg-url, author ready Commits 1 - benchmark: update benchmark for URLSearchParams.sort Committers 1 - zhenweijin PR-URL: https://github.com/nodejs/node/pull/50568 Fixes: https://github.com/nodejs/node/issues/50566 Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50568 Fixes: https://github.com/nodejs/node/issues/50566 Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 Nov 2023 17:08:56 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50568#pullrequestreview-1721005209 ✘ This PR needs to wait 91 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6804435402 |
MrJithil
reviewed
Nov 10, 2023
| bench.start(); | ||
| for (let i = 0; i < n; i++) { | ||
| params[searchParams] = array.slice(); | ||
| params.sort(); |
There was a problem hiding this comment.
Now, this sort really needed? Its doing the same operation n times. We are not modifying any values inside the params
anonrig
requested changes
Nov 10, 2023
kylo5aby
force-pushed
the
update-benchmark
branch
from
28e4257 to
7e1f1a7
Compare
Good point. As @MrJithil mentioned, |
debadree25
removed
author ready
|
@anonrig PTAL feel free |
legendecas
reviewed
Jun 19, 2024
| out.push(key, ''); | ||
| } | ||
| return out; | ||
| return str.split('&'); |
There was a problem hiding this comment.
I think the original getParams is correct on returning a params initialization array. After the change, it is partial and needs more work at line 33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
searchParamsSymbolfromurl-searchparams-sort.js.Fixes: #50566