tools: avoid npm install in deps installation#50413
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Oct 30, 2023
Merged
tools: avoid npm install in deps installation#50413nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
lpinca
reviewed
Oct 26, 2023
anonrig
approved these changes
Oct 27, 2023
anonrig
added
the
commit-queue-squash
lpinca
approved these changes
Oct 27, 2023
|
|
||
| tar -xf "$ACORN_WALK_TGZ" | ||
|
|
||
| mv "$WORKSPACE/package"/* "$DEPS_DIR/acorn/acorn-walk" |
Member
There was a problem hiding this comment.
Suggested change
| mv "$WORKSPACE/package"/* "$DEPS_DIR/acorn/acorn-walk" | |
| mv package/* "$DEPS_DIR/acorn/acorn-walk" |
|
|
||
| mv "$WORKSPACE/package"/* "$DEPS_DIR/acorn/acorn-walk" | ||
|
|
||
| rm "$ACORN_WALK_TGZ" |
Member
There was a problem hiding this comment.
Suggested change
| rm "$ACORN_WALK_TGZ" |
Removed on cleanup.
jasnell
approved these changes
Oct 28, 2023
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ecf0330 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50413 Refs: nodejs#49747 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #49747
To avoid doing:
npm initnpm install acorn-walkwe can download the tarball directly from npm