tests: New zlib version is 1.3, which only has two elements#50364
tests: New zlib version is 1.3, which only has two elements#50364nodejs-github-bot merged 1 commit intonodejs:mainfrom DimStar77:zlib1.3
Conversation
|
Background:
With this constellation, the test suite failed with |
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version.
|
I think a better approach would be to skip the assertion when Node.js is built with the |
|
Neverming, commit message is ok. I was tricked by PR title. |
Commit message looks okay (it was already changed from the PR title). |
My bad - that was the 'original' commit message, saw the bot complaining about this and rewrote it - hopefully to comply |
|
Landed in 5d01042 |
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Change the test code to accept one, two, or three elements past the major version