Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add benchmarks for encodings #50348

Merged
merged 1 commit into from
Oct 25, 2023
Merged

benchmark: add benchmarks for encodings #50348

merged 1 commit into from
Oct 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 23, 2023

Adds benchmarks for base64url and improves the benchmarks for hex

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Oct 23, 2023
@Uzlopak Uzlopak mentioned this pull request Oct 23, 2023
Open
H4ad
H4ad reviewed Oct 23, 2023
View reviewed changes
benchmark/buffers/buffer-hex-decoded.js Outdated Show resolved Hide resolved
benchmark/buffers/buffer-base64url-encode.js Outdated Show resolved Hide resolved
benchmark/buffers/buffer-base64url-decode.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 23, 2023

@H4ad
done

@H4ad H4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55184/

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit d895130 into nodejs:main Oct 25, 2023
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d895130

@Uzlopak Uzlopak deleted the benchmarks-encodings branch October 25, 2023 20:52
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@Uzlopak @alexfernandez
benchmark: add benchmarks for encodings
4c39840 
PR-URL: nodejs#50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak @targos
benchmark: add benchmarks for encodings
3f37ed9 
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@Uzlopak @UlisesGascon
benchmark: add benchmarks for encodings
15c2ed9 
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Uzlopak @nodejs-github-bot @anonrig @H4ad