Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: update default platform to override functions with location #50289

Closed
wants to merge 10 commits into from

Conversation

eti-p-doray
Copy link
Contributor

v8 platform is migrating to PostTask functions with location.
https://chromium-review.googlesource.com/c/v8/v8/+/4336198

This PR updates default platform to overrides the new versions of functions.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 19, 2023
@eti-p-doray eti-p-doray marked this pull request as draft October 19, 2023 14:54
@eti-p-doray eti-p-doray marked this pull request as ready for review October 19, 2023 14:56
@targos
Copy link
Member

targos commented Oct 19, 2023

@nodejs/cpp-reviewers

@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 19, 2023
@eti-p-doray
Copy link
Contributor Author

I fix the linting issues (I think)
CI shows test-inspector-wait-for-connection timeouts, but I'm not sure that's related to this PR; the test runs fine locally on mac.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@nodejs-github-bot
Copy link
Collaborator

@eti-p-doray
Copy link
Contributor Author

I'm not sure what to do with the CI failure. e.g. macOs shows

Path: parallel/test-release-changelog
Error: --- stderr ---
node:assert:1026
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /<b><a href="doc\/changelogs\/CHANGELOG_V21.md#21\.0\.0">21\.0\.0<\/a><\/b><br\/>/. Input:
...

Is this failure related to this PR?

@RafaelGSS
Copy link
Member

I'm not sure what to do with the CI failure. e.g. macOs shows

Path: parallel/test-release-changelog
Error: --- stderr ---
node:assert:1026
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /<b><a href="doc\/changelogs\/CHANGELOG_V21.md#21\.0\.0">21\.0\.0<\/a><\/b><br\/>/. Input:
...

Is this failure related to this PR?

Can you rebase on main?

@eti-p-doray
Copy link
Contributor Author

I rebased to latest commit on main

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2023
@nodejs-github-bot
Copy link
Collaborator

@eti-p-doray
Copy link
Contributor Author

All checks have passed but merging is restricted.

@eti-p-doray
Copy link
Contributor Author

I think I need an authorized user to merge it, @targos?

@lpinca
Copy link
Member

lpinca commented Dec 29, 2023

@eti-p-doray please remove the merge commits.

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This landed as part of #51362. Thanks for the contribution!

@aduh95 aduh95 closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants