-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8: update default platform to override functions with location #50289
Conversation
v8 platform is migrating to PostTask functions with location. https://chromium-review.googlesource.com/c/v8/v8/+/4336198
@nodejs/cpp-reviewers |
I fix the linting issues (I think) |
I'm not sure what to do with the CI failure. e.g. macOs shows
Is this failure related to this PR? |
Can you rebase on |
I rebased to latest commit on main |
All checks have passed but merging is restricted. |
I think I need an authorized user to merge it, @targos? |
@eti-p-doray please remove the merge commits. |
This landed as part of #51362. Thanks for the contribution! |
v8 platform is migrating to PostTask functions with location.
https://chromium-review.googlesource.com/c/v8/v8/+/4336198
This PR updates default platform to overrides the new versions of functions.