esm: rename error code related to import attributes#50181
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Oct 18, 2023
Merged
esm: rename error code related to import attributes#50181nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
aduh95
added
experimental
Collaborator
|
Review requested:
|
nodejs-github-bot
added
errors
| removed: REPLACEME | ||
| --> | ||
|
|
||
| An import assertion has failed, preventing the specified module to be imported. |
Member
There was a problem hiding this comment.
Suggested change
| An import assertion has failed, preventing the specified module to be imported. | |
| An import assertion has failed, preventing the specified module being imported. |
Contributor
Author
There was a problem hiding this comment.
I'd prefer to keep it as is, it's the wording used today in https://nodejs.org/api/errors.html#err_import_assertion_type_failed.
| removed: REPLACEME | ||
| --> | ||
|
|
||
| An import assertion is missing, preventing the specified module to be imported. |
Member
There was a problem hiding this comment.
Suggested change
| An import assertion is missing, preventing the specified module to be imported. | |
| An import assertion is missing, preventing the specified module being imported. |
GeoffreyBooth
approved these changes
Oct 14, 2023
GeoffreyBooth
approved these changes
Oct 14, 2023
himself65
approved these changes
Oct 14, 2023
Contributor
Author
|
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3333/ Test failures seems to match the ones happening on 21.0.0 release proposal, the only addition is torrent-stream but that's a timeout. |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 37d4f08 |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50181 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50181 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Member
|
Why is this |
This was referenced Dec 13, 2023
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Dec 13, 2023
PR-URL: nodejs#50181 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Contributor
Author
|
I'm pretty sure I added the |
Contributor
Author
|
Ah no, I remember now, this PR changes the error codes, and that could break existing code. |
Member
|
Aren't we allowed to break code since this is an experimental feature? |
Member
|
Forget it. We can keep this out of LTS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.